-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13300][Documentation] Added pygments.rb dependancy #11180
Conversation
@amitdev The PR also contains ml-guide changes. Could you remove that commit from your branch? |
@mengxr, Sorry I committed that by mistake - removed now. Thanks! |
@amitdev can you connect this to https://issues.apache.org/jira/browse/SPARK-13300 in the title? it might be the same thing? It looks like lots of the examples aren't rendered in the current live site? |
@srowen, it looks related - is there a way to verify it? I couldn't locate where the spark example code is. Things on the main documentation site is working fine. Anyway I'll change the title so that someone with access can take a look. |
@amitdev just build the documentation. Do you see the code snippets correctly in the page http://spark.apache.org/examples.html in your local build? instead of the pygments error? |
Aha, one significant update. Yes, the change here is a good one, as I also had to install this gem to build the docs. In fact we can simplify:
Maybe it's also worth noting that you'd have to have Ruby and pip installed (and I assume gcc, Python already), which may not be obvious. For Ubuntu that's:
I don't feel strongly about adding that, but hey. Actually I was incorrect in connecting this to SPARK-13300 though, as the page in question is not generated from source in While we can just add this change (with a possible simplification) I'm also looking at whether I can fix up the ASF site with something similar. |
I fixed the ASF site at http://spark.apache.org/examples.html and indeed it required the same gem to be installed to work. So this is related. |
Thanks @srowen. I've mentioned dependencies on Ruby, Python and cleaned up the doc a little. |
Jenkins test this please |
Test build #51265 has finished for PR 11180 at commit
|
Looks like pygments.rb gem is also required for jekyll build to work. At least on Ubuntu/RHEL I could not do build without this dependency. So added this to steps. Author: Amit Dev <amitdev@gmail.com> Closes #11180 from amitdev/master. (cherry picked from commit 331293c) Signed-off-by: Sean Owen <sowen@cloudera.com>
Merged to master/1.6. @amitdev if you'll tell me your JIRA handle I'll assign you. |
@srowen, my JIRA handle is amitdev. |
@amitdev I don't see anyone by your name or "Amit Dev.." in ASF JIRA. Are you sure? maybe link me to your profile page |
Looks like pygments.rb gem is also required for jekyll build to work. At least on Ubuntu/RHEL I could not do build without this dependency. So added this to steps.