[SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES ddl #17649

sujith71955 · 2017-04-16T12:12:30Z

What changes were proposed in this pull request?

Table comment was not getting set/unset using ALTER TABLE SET/UNSET TBLPROPERTIES query
eg: ALTER TABLE table_with_comment SET TBLPROPERTIES("comment"= "modified comment)
when user alter the table properties and adds/updates table comment,table comment which is a field of CatalogTable instance is not getting updated and old table comment if exists was shown to user, inorder to handle this issue, update the comment field value in CatalogTable with the newly added/modified comment along with other table level properties when user executes ALTER TABLE SET TBLPROPERTIES query.

This pr has also taken care of unsetting the table comment when user executes query ALTER TABLE UNSET TBLPROPERTIES inorder to unset or remove table comment.
eg: ALTER TABLE table_comment UNSET TBLPROPERTIES IF EXISTS ('comment')

How was this patch tested?

Added test cases as part of SQLQueryTestSuite for verifying table comment using desc formatted table query after adding/modifying table comment as part of AlterTableSetPropertiesCommand and unsetting the table comment using AlterTableUnsetPropertiesCommand.

sujith71955 · 2017-04-16T12:17:20Z

cc @wzhfy

wzhfy · 2017-04-16T14:52:42Z

test this please

wzhfy · 2017-04-16T14:55:16Z

also cc @gatorsmile

wzhfy · 2017-04-16T14:58:19Z

@sujith71955 Can you change the title to be more specific, like "Support altering table comment"?

wzhfy · 2017-04-16T15:00:34Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala

-    val newTable = table.copy(properties = table.properties ++ properties)
+    val newTable = table.copy(
+      properties = table.properties ++ properties,
+      comment = properties.get("comment"))


add some comment to explain why this is necessary?

I will add a comment

gatorsmile · 2017-04-16T17:31:49Z

ok to test

gatorsmile · 2017-04-16T17:32:28Z

This is a separate issue. Could you open a new JIRA and use a different JIRA number?

gatorsmile · 2017-04-16T18:10:02Z

sql/core/src/test/resources/sql-tests/inputs/describe_tbleproperty_validation.sql

+DESC formatted table_comment;
+
+-- DROP TEST TABLE
+DROP TABLE table_comment;


The basic function has been tested in the other suites. How about changing this test suite to describe-table-after-alter-table?

CREATE TABLE table_comment (a STRING, b INT) -- ALTER TABLE BY ADDING COMMENT ALTER TABLE table_comment set tblproperties(comment = "added comment"); DESC formatted table_comment; -- ALTER TABLE BY MODIFYING COMMENT ALTER TABLE table_comment set tblproperties(comment = "modified comment"); DESC formatted table_comment; -- DROP TEST TABLE DROP TABLE table_comment;

It sounds we also have a bug in the ALTER TABLE UNSET.

Please also add another test case

-- ALTER TABLE BY UNSETTING COMMENT ALTER TABLE table_comment unset tblproperties('comment');

sure, i will add a new jira for this problem and i will update the test suite name as per the suggestion, as you suggested i will also verify ALTER TABLE UNSET .

SparkQA · 2017-04-16T18:57:46Z

Test build #75840 has finished for PR 17649 at commit 1db3103.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-04-20T04:52:19Z

Any update? ping @sujith71955 @wzhfy

sujith71955 · 2017-04-20T18:49:51Z

@gatorsmile @wzhfy updated the PR based on the review comments, please let me know for any suggestions.

SparkQA · 2017-04-20T20:43:05Z

Test build #76002 has finished for PR 17649 at commit 467a694.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-04-20T20:59:20Z

Test build #76004 has finished for PR 17649 at commit 19d80c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

wzhfy · 2017-04-21T08:03:02Z

sql/core/src/test/resources/sql-tests/results/describe-table-after-alter-table.sql.out

+Type                	MANAGED             	                    
+Provider            	parquet             	                    
+Comment             	modified comment    	                    
+Properties          	[comment=modified comment]	                    


Comment string i.e. "modified comment" is in both Properties and Comment?

We should remove comment from Properties

yes, i saw for hive tables already its been taken care in HiveClientImpl.scala class where "comment" is getting filtered from table properties, also for parquet table same has to be taken care.

wzhfy · 2017-04-21T08:05:33Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+DESC formatted table_with_comment;
+
+-- ALTER TABLE BY MODIFYING COMMENT
+ALTER TABLE table_with_comment set tblproperties(comment = "modified comment");


I think it would be better to also have other properties with comment in this test.

rename describe-table-after-alter-table.sql to alter-table-comment.sql?

nvm I missed your previous discussion

modified the testcase as per comment, added one more proeprty while altering the table.

wzhfy · 2017-04-21T08:09:38Z

@gatorsmile Should we care about case sensitivity of comment? Hive allows both "comment" and "Comment" in table parameters, while we are extracting comment as a field of CatalogTable.

gatorsmile · 2017-04-23T04:22:12Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala

+      None
+    } else {
+      table.properties.get("comment")
+    }


Nit:

val comment = if (propKeys.contains("comment")) None else table.properties.get("comment")

gatorsmile · 2017-04-23T04:30:32Z

@wzhfy Could you check the behavior of Hive?

SparkQA · 2017-04-23T20:26:23Z

Test build #76085 has finished for PR 17649 at commit 50deed9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

wzhfy · 2017-04-24T03:52:00Z

@gatorsmile Hive treats comment simply as a key in the string-string parameter map, while spark extracts comment from the map as a field in CatalogTable. So the question is, should spark consider both comment and COMMENT as table comment? If yes, what if they are different?

Here's the results of hive:

0: jdbc:hive2://.../> create table src (key int , value string) comment "initial comment";
No rows affected (1.055 seconds)
0: jdbc:hive2://.../> desc formatted src;
+-------------------------------+-------------------------------------------------------+-----------------------+--+
|           col_name            |                       data_type                       |        comment        |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
| # col_name                    | data_type                                             | comment               |
|                               | NULL                                                  | NULL                  |
| key                           | int                                                   |                       |
| value                         | string                                                |                       |
|                               | NULL                                                  | NULL                  |
| # Detailed Table Information  | NULL                                                  | NULL                  |
| Database:                     | wzh                                                   | NULL                  |
| Owner:                        | spark                                                 | NULL                  |
| CreateTime:                   | Mon Apr 24 11:43:40 CST 2017                          | NULL                  |
| LastAccessTime:               | UNKNOWN                                               | NULL                  |
| Protect Mode:                 | None                                                  | NULL                  |
| Retention:                    | 0                                                     | NULL                  |
| Location:                     | hdfs://hacluster/user/hive/warehouse/wzh.db/src       | NULL                  |
| Table Type:                   | MANAGED_TABLE                                         | NULL                  |
| Table Parameters:             | NULL                                                  | NULL                  |
|                               | comment                                               | initial comment       |
|                               | transient_lastDdlTime                                 | 1493005420            |
|                               | NULL                                                  | NULL                  |
| # Storage Information         | NULL                                                  | NULL                  |
| SerDe Library:                | org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe  | NULL                  |
| InputFormat:                  | org.apache.hadoop.hive.ql.io.RCFileInputFormat        | NULL                  |
| OutputFormat:                 | org.apache.hadoop.hive.ql.io.RCFileOutputFormat       | NULL                  |
| Compressed:                   | No                                                    | NULL                  |
| Num Buckets:                  | -1                                                    | NULL                  |
| Bucket Columns:               | []                                                    | NULL                  |
| Sort Columns:                 | []                                                    | NULL                  |
| Storage Desc Params:          | NULL                                                  | NULL                  |
|                               | serialization.format                                  | 1                     |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
28 rows selected (0.525 seconds)
0: jdbc:hive2://.../> alter table src set tblproperties("comment"="new comment", "COMMENT"="NEW COMMENT");
No rows affected (0.62 seconds)
0: jdbc:hive2://.../> desc formatted src;
+-------------------------------+-------------------------------------------------------+-----------------------+--+
|           col_name            |                       data_type                       |        comment        |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
| # col_name                    | data_type                                             | comment               |
|                               | NULL                                                  | NULL                  |
| key                           | int                                                   |                       |
| value                         | string                                                |                       |
|                               | NULL                                                  | NULL                  |
| # Detailed Table Information  | NULL                                                  | NULL                  |
| Database:                     | wzh                                                   | NULL                  |
| Owner:                        | spark                                                 | NULL                  |
| CreateTime:                   | Mon Apr 24 11:43:40 CST 2017                          | NULL                  |
| LastAccessTime:               | UNKNOWN                                               | NULL                  |
| Protect Mode:                 | None                                                  | NULL                  |
| Retention:                    | 0                                                     | NULL                  |
| Location:                     | hdfs://hacluster/user/hive/warehouse/wzh.db/src       | NULL                  |
| Table Type:                   | MANAGED_TABLE                                         | NULL                  |
| Table Parameters:             | NULL                                                  | NULL                  |
|                               | COLUMN_STATS_ACCURATE                                 | false                 |
|                               | COMMENT                                               | NEW COMMENT           |
|                               | comment                                               | new comment           |
|                               | last_modified_by                                      | spark                 |
|                               | last_modified_time                                    | 1493005506            |
|                               | numFiles                                              | 0                     |
|                               | numRows                                               | -1                    |
|                               | rawDataSize                                           | -1                    |
|                               | totalSize                                             | 0                     |
|                               | transient_lastDdlTime                                 | 1493005506            |
|                               | NULL                                                  | NULL                  |
| # Storage Information         | NULL                                                  | NULL                  |
| SerDe Library:                | org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe  | NULL                  |
| InputFormat:                  | org.apache.hadoop.hive.ql.io.RCFileInputFormat        | NULL                  |
| OutputFormat:                 | org.apache.hadoop.hive.ql.io.RCFileOutputFormat       | NULL                  |
| Compressed:                   | No                                                    | NULL                  |
| Num Buckets:                  | -1                                                    | NULL                  |
| Bucket Columns:               | []                                                    | NULL                  |
| Sort Columns:                 | []                                                    | NULL                  |
| Storage Desc Params:          | NULL                                                  | NULL                  |
|                               | serialization.format                                  | 1                     |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
36 rows selected (0.337 seconds)
0: jdbc:hive2://.../> alter table src unset tblproperties ("COMMENT");
No rows affected (0.646 seconds)
0: jdbc:hive2://.../> desc formatted src;
+-------------------------------+-------------------------------------------------------+-----------------------+--+
|           col_name            |                       data_type                       |        comment        |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
| # col_name                    | data_type                                             | comment               |
|                               | NULL                                                  | NULL                  |
| key                           | int                                                   |                       |
| value                         | string                                                |                       |
|                               | NULL                                                  | NULL                  |
| # Detailed Table Information  | NULL                                                  | NULL                  |
| Database:                     | wzh                                                   | NULL                  |
| Owner:                        | spark                                                 | NULL                  |
| CreateTime:                   | Mon Apr 24 11:43:40 CST 2017                          | NULL                  |
| LastAccessTime:               | UNKNOWN                                               | NULL                  |
| Protect Mode:                 | None                                                  | NULL                  |
| Retention:                    | 0                                                     | NULL                  |
| Location:                     | hdfs://hacluster/user/hive/warehouse/wzh.db/src       | NULL                  |
| Table Type:                   | MANAGED_TABLE                                         | NULL                  |
| Table Parameters:             | NULL                                                  | NULL                  |
|                               | COLUMN_STATS_ACCURATE                                 | false                 |
|                               | comment                                               | new comment           |
|                               | last_modified_by                                      | spark                 |
|                               | last_modified_time                                    | 1493005605            |
|                               | numFiles                                              | 0                     |
|                               | numRows                                               | -1                    |
|                               | rawDataSize                                           | -1                    |
|                               | totalSize                                             | 0                     |
|                               | transient_lastDdlTime                                 | 1493005605            |
|                               | NULL                                                  | NULL                  |
| # Storage Information         | NULL                                                  | NULL                  |
| SerDe Library:                | org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe  | NULL                  |
| InputFormat:                  | org.apache.hadoop.hive.ql.io.RCFileInputFormat        | NULL                  |
| OutputFormat:                 | org.apache.hadoop.hive.ql.io.RCFileOutputFormat       | NULL                  |
| Compressed:                   | No                                                    | NULL                  |
| Num Buckets:                  | -1                                                    | NULL                  |
| Bucket Columns:               | []                                                    | NULL                  |
| Sort Columns:                 | []                                                    | NULL                  |
| Storage Desc Params:          | NULL                                                  | NULL                  |
|                               | serialization.format                                  | 1                     |
+-------------------------------+-------------------------------------------------------+-----------------------+--+
35 rows selected (0.552 seconds)

SparkQA · 2017-04-25T16:34:11Z

Test build #76139 has finished for PR 17649 at commit 1156483.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-04-25T19:09:16Z

Test build #76142 has finished for PR 17649 at commit 99ba5be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

sujith71955 · 2017-04-25T23:59:16Z

@gatorsmile @wzhfy updated the PR by removing the 'comment' from table properties .

wzhfy · 2017-04-26T02:41:56Z

The changes look good to me if we don't care about the case sensitivity issue.

gatorsmile · 2017-04-26T06:13:22Z

@wzhfy In HiveClientImpl.scala, we follow Hive and consider the case sensitivity of property key comment.

@sujith71955 Could you resolve the following comment?
#17649 (comment)

gatorsmile · 2017-05-04T21:00:39Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala

@@ -267,8 +271,11 @@ case class AlterTableUnsetPropertiesCommand(
        }
      }
    }
+    // if 'comment' key is present in the seq of keys which needs to be unset then reset the table
+    // level comment with none.


Nit: How about?

If comment is in the table property, we reset it to None

gatorsmile · 2017-05-04T21:01:04Z

sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala

@@ -222,7 +222,6 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
      } else {
        tableDefinition.storage.locationUri
      }
-


Please revert it back.

gatorsmile · 2017-05-04T21:02:38Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

@@ -0,0 +1,29 @@
+CREATE TABLE table_with_comment (a STRING, b INT, c STRING, d STRING) USING parquet COMMENT 'added';
+
+DESC formatted table_with_comment;


Nit: formatted -> FORMATTED

gatorsmile · 2017-05-04T21:02:42Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+-- ALTER TABLE BY MODIFYING COMMENT
+ALTER TABLE table_with_comment set tblproperties("comment"= "modified comment", "type"= "parquet");
+
+DESC formatted table_with_comment;


Nit: formatted -> FORMATTED

gatorsmile · 2017-05-04T21:02:50Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+-- ALTER TABLE BY ADDING COMMENT
+ALTER TABLE table_comment set tblproperties(comment = "added comment");
+
+DESC formatted table_comment;


Nit: formatted -> FORMATTED

gatorsmile · 2017-05-04T21:02:55Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+-- ALTER UNSET PROPERTIES COMMENT
+ALTER TABLE table_comment UNSET TBLPROPERTIES IF EXISTS ('comment');
+
+DESC formatted table_comment;


Nit: formatted -> FORMATTED

gatorsmile · 2017-05-04T21:03:22Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+DESC formatted table_comment;
+
+-- ALTER TABLE BY ADDING COMMENT
+ALTER TABLE table_comment set tblproperties(comment = "added comment");


Nit: set tblproperties -> SET TBLPROPERTIES

gatorsmile · 2017-05-04T21:03:31Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+DESC formatted table_with_comment;
+
+-- ALTER TABLE BY MODIFYING COMMENT
+ALTER TABLE table_with_comment set tblproperties("comment"= "modified comment", "type"= "parquet");


Nit: set tblproperties -> SET TBLPROPERTIES

gatorsmile · 2017-05-04T21:03:42Z

sql/core/src/test/resources/sql-tests/inputs/describe-table-after-alter-table.sql

+-- CREATE TABLE WITHOUT COMMENT
+CREATE TABLE table_comment (a STRING, b INT) USING parquet;
+
+DESC formatted table_comment;


Nit: formatted -> FORMATTED

gatorsmile · 2017-05-04T21:04:11Z

LGTM except a few minor comments.

…ding/modifying table comment using Alter TableSetPropertiesCommand and UNSET TBLPROPERTIES query. ### What changes were proposed in this pull request? This PR is a follow up PR to JIRA issue 20023 where table comment was not displayed in describe formatted command after user creates a table with table comment. But still was issue when user alter the table properties and adds/updates table comment. table comment which is directly part of CatalogTable instance where not getting updated and old table comment was shown, to handle this issue while updating the table properties map with newly added/modified properties in CatalogTable instance also update the comment parameter with newly added/modified comment as part of AlterTableSetPropertiesCommand which is also now exist in CatalogTable instance level not only in table properties map of CatalogTable instance. this pr has also taken care of unsetting the table comment when user executes AlterTableUnsetPropertiesCommand. ### How was this patch tested? Added test cases as part of SQLQueryTestSuite for verifying table comment using desc formatted table query after adding or modifying table comment as part of AlterTableSetPropertiesCommand and AlterTableUnsetPropertiesCommand.

SparkQA · 2017-05-05T16:58:27Z

Test build #76496 has finished for PR 17649 at commit 4f02ada.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

sujith71955 · 2017-05-05T17:21:57Z

@wzhfy @gatorsmile fixed all the comments, thanks for reviewing the changes and providing me valuable sharings and comments. thanks.

gatorsmile · 2017-05-05T19:10:47Z

@sujith71955 Could you update the PR description and title?

This PR is to fix the issue in modify table comments using ALTER TABLE SET/UNSET TBLPROPERTIES, instead of fixing the DESC FORMATTED, right?

sujith71955 · 2017-05-06T04:36:14Z

@gatorsmile you are right, pr should address the issue which is handled in alter table set/unset properties ddls, updated the description and title, let me know for any clarifications. thanks.

gatorsmile · 2017-05-07T21:22:46Z

retest this please

SparkQA · 2017-05-07T23:41:10Z

Test build #76551 has finished for PR 17649 at commit 4f02ada.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-05-08T06:15:20Z

Thanks! Merging to master.

…LTER TABLE SET/UNSET TBLPROPERTIES ddl ### What changes were proposed in this pull request? Table comment was not getting set/unset using **ALTER TABLE SET/UNSET TBLPROPERTIES** query eg: ALTER TABLE table_with_comment SET TBLPROPERTIES("comment"= "modified comment) when user alter the table properties and adds/updates table comment,table comment which is a field of **CatalogTable** instance is not getting updated and old table comment if exists was shown to user, inorder to handle this issue, update the comment field value in **CatalogTable** with the newly added/modified comment along with other table level properties when user executes **ALTER TABLE SET TBLPROPERTIES** query. This pr has also taken care of unsetting the table comment when user executes query **ALTER TABLE UNSET TBLPROPERTIES** inorder to unset or remove table comment. eg: ALTER TABLE table_comment UNSET TBLPROPERTIES IF EXISTS ('comment') ### How was this patch tested? Added test cases as part of **SQLQueryTestSuite** for verifying table comment using desc formatted table query after adding/modifying table comment as part of **AlterTableSetPropertiesCommand** and unsetting the table comment using **AlterTableUnsetPropertiesCommand**. Author: sujith71955 <sujithchacko.2010@gmail.com> Closes apache#17649 from sujith71955/alter_table_comment.

## What changes were proposed in this pull request? Test failed in `describe.sql`. We need to fix the related bug introduced in (#17649) in the follow-up PR to master. ## How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes #18316 from gatorsmile/fix.

wzhfy reviewed Apr 16, 2017

View reviewed changes

gatorsmile reviewed Apr 16, 2017

View reviewed changes

sujith71955 force-pushed the alter_table_comment branch 2 times, most recently from 467a694 to 19d80c6 Compare April 20, 2017 18:48

wzhfy reviewed Apr 21, 2017

View reviewed changes

gatorsmile reviewed Apr 23, 2017

View reviewed changes

sujith71955 force-pushed the alter_table_comment branch from 19d80c6 to 50deed9 Compare April 23, 2017 18:14

sujith71955 force-pushed the alter_table_comment branch from 50deed9 to 1156483 Compare April 25, 2017 16:29

sujith71955 force-pushed the alter_table_comment branch from 1156483 to 99ba5be Compare April 25, 2017 16:53

gatorsmile reviewed May 4, 2017

View reviewed changes

sujith71955 force-pushed the alter_table_comment branch from 433ac2b to 4f02ada Compare May 5, 2017 14:41

sujith71955 changed the title ~~[SPARK-20380][SQL] Output table comment for DESC FORMATTED after adding/modifying table comment using Alter TableSetPropertiesCommand~~ [SPARK-20380][SQL] Unable to modify table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES May 6, 2017

sujith71955 changed the title ~~[SPARK-20380][SQL] Unable to modify table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES~~ [SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES May 6, 2017

sujith71955 changed the title ~~[SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES~~ [SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES ddl May 6, 2017

asfgit closed this in 42cc6d1 May 8, 2017

This was referenced May 8, 2017

[SPARK-20626][SPARKR] address date test warning with timezone on windows #17892

Closed

[SPARK-20661][SparkR][Test] SparkR tableNames() test fails #17903

Closed

gatorsmile mentioned this pull request Jun 15, 2017

[SPARK-21111] [TEST] [2.2] Fix the test failure of describe.sql #18316

Closed

		@@ -0,0 +1,29 @@
		CREATE TABLE table_with_comment (a STRING, b INT, c STRING, d STRING) USING parquet COMMENT 'added';

		DESC formatted table_with_comment;

[SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES ddl #17649

[SPARK-20380][SQL] Unable to set/unset table comment property using ALTER TABLE SET/UNSET TBLPROPERTIES ddl #17649

Conversation

sujith71955 commented Apr 16, 2017 • edited Loading

What changes were proposed in this pull request?

How was this patch tested?

sujith71955 commented Apr 16, 2017

wzhfy commented Apr 16, 2017

wzhfy commented Apr 16, 2017

wzhfy commented Apr 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gatorsmile commented Apr 16, 2017

gatorsmile commented Apr 16, 2017

Choose a reason for hiding this comment

gatorsmile Apr 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparkQA commented Apr 16, 2017

gatorsmile commented Apr 20, 2017 • edited Loading

sujith71955 commented Apr 20, 2017

SparkQA commented Apr 20, 2017

SparkQA commented Apr 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wzhfy Apr 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wzhfy commented Apr 21, 2017

Choose a reason for hiding this comment

gatorsmile commented Apr 23, 2017

SparkQA commented Apr 23, 2017

wzhfy commented Apr 24, 2017 • edited Loading

SparkQA commented Apr 25, 2017

SparkQA commented Apr 25, 2017

sujith71955 commented Apr 25, 2017

wzhfy commented Apr 26, 2017

gatorsmile commented Apr 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gatorsmile commented May 4, 2017

SparkQA commented May 5, 2017

sujith71955 commented May 5, 2017

gatorsmile commented May 5, 2017 • edited Loading

sujith71955 commented May 6, 2017

gatorsmile commented May 7, 2017

SparkQA commented May 7, 2017

gatorsmile commented May 8, 2017

sujith71955 commented Apr 16, 2017 •

edited

Loading

gatorsmile Apr 16, 2017 •

edited

Loading

gatorsmile commented Apr 20, 2017 •

edited

Loading

wzhfy Apr 21, 2017 •

edited

Loading

wzhfy commented Apr 24, 2017 •

edited

Loading

gatorsmile commented May 5, 2017 •

edited

Loading