[SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s.deploy.master.MasterSuite.master correctly recover the application" #18321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I20f1a68b682cbfda05be319b365495c80fb4cda4
cloud-fan
reviewed
Jun 16, 2017
| @@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite | |||
| master.rpcEnv.setupEndpoint(Master.ENDPOINT_NAME, master) | |||
| // Wait until Master recover from checkpoint data. | |||
| eventually(timeout(5 seconds), interval(100 milliseconds)) { | |||
| master.idToApp.size should be(1) | |||
| master.workers.size should be(1) | |||
There was a problem hiding this comment.
can you explain more about why it may fail?
There was a problem hiding this comment.
I think the reason is workers are recovered later than applications.
There was a problem hiding this comment.
yes, that's right.
|
LGTM |
|
Test build #78150 has finished for PR 18321 at commit
|
|
thanks, merging to master/2.2 |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2017
…rSuite.master correctly recover the application" ## What changes were proposed in this pull request? Due to the RPC asynchronous event processing, The test "correctly recover the application" could potentially be failed. The issue could be found in here: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78126/testReport/org.apache.spark.deploy.master/MasterSuite/master_correctly_recover_the_application/. So here fixing this flaky test. ## How was this patch tested? Existing UT. CC cloud-fan jiangxb1987 , please help to review, thanks! Author: jerryshao <sshao@hortonworks.com> Closes #18321 from jerryshao/SPARK-12552-followup. (cherry picked from commit 2837b14) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Due to the RPC asynchronous event processing, The test "correctly recover the application" could potentially be failed. The issue could be found in here: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78126/testReport/org.apache.spark.deploy.master/MasterSuite/master_correctly_recover_the_application/.
So here fixing this flaky test.
How was this patch tested?
Existing UT.
CC @cloud-fan @jiangxb1987 , please help to review, thanks!