Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22107] Change as to alias in python quickstart #19326

Closed
wants to merge 1 commit into from
Closed

[SPARK-22107] Change as to alias in python quickstart #19326

wants to merge 1 commit into from

Conversation

jgoleary
Copy link

@jgoleary jgoleary commented Sep 22, 2017 •
edited
Loading

What changes were proposed in this pull request?

Updated docs so that a line of python in the quick start guide executes. Closes #19283

How was this patch tested?

Existing tests.

@HyukjinKwon
Copy link
Member

How does it relate to #19283?

@jgoleary
Copy link
Author

@HyukjinKwon looks like this does the same thing as name() is an alias for alias(). Happy to close but suggest merging one of these to help future noobs.

@HyukjinKwon
Copy link
Member

That's fine. I believe we don't usually need a JIRA for a trivial change though. Would you mind double checking if there are similar instances in the PySpark doc?

Also, it'd be great if we add Closes #19283 in the PR description so that #19283 can be automatically closed when this PR is merged. It looks #19283 has gone inactive.

@jgoleary
Copy link
Author

Updated description. The only other mentions of as() I can find in the docs are in Java examples, and the method appears to exist on the Java side.

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Sep 24, 2017

Test build #82139 has finished for PR 19326 at commit c6bf156.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Sep 25, 2017
@HyukjinKwon
[SPARK-22107] Change as to alias in python quickstart
8acce00 
## What changes were proposed in this pull request?

Updated docs so that a line of python in the quick start guide executes. Closes #19283

## How was this patch tested?

Existing tests.

Author: John O'Leary <jgoleary@gmail.com>

Closes #19326 from jgoleary/issues/22107.

(cherry picked from commit 20adf9a)
Signed-off-by: hyukjinkwon <gurwls223@gmail.com>
@asfgit asfgit closed this in 20adf9a Sep 25, 2017
@HyukjinKwon
Copy link
Member

Merged to master and branch-2.2.

@jgoleary, I merged this considering the first contribution but let's do this in a batch if possible in the future.

MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
@MatthewRBruce
[SPARK-22107] Change as to alias in python quickstart
544a18d 
## What changes were proposed in this pull request?

Updated docs so that a line of python in the quick start guide executes. Closes apache#19283

## How was this patch tested?

Existing tests.

Author: John O'Leary <jgoleary@gmail.com>

Closes apache#19326 from jgoleary/issues/22107.

(cherry picked from commit 20adf9a)
Signed-off-by: hyukjinkwon <gurwls223@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgoleary @HyukjinKwon @SparkQA