Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21809] : Change Stage Page to use datatables to support sorting columns and searching #21688

Closed
wants to merge 48 commits into from
Closed
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
5450258
[SPARK-21809] : Changing file executorspage-template.html and executo…
Jun 4, 2018
dadc55f
[SPARK-21809] : Making changes in ui resources files
Jun 4, 2018
fc88dec
[SPARK-21809] : Getting rquired data in api endpoints
Jun 15, 2018
495caaf
[SPARK-21809] : Rendering the ui compatible with current version usin…
Jun 20, 2018
c1d41d8
Working on Adding Server Side Sort Functionality
Jun 22, 2018
567d22b
[SPARK-21809] : Implement Server Side Sorting Functionality
Jun 25, 2018
649e95b
[SPARK-21809] : Implementing server side pagination and searching fun…
Jun 27, 2018
590e93f
[SPARK-21809] : Fixing Tests and task metric table
Jul 1, 2018
d79eb80
[SPARK-21809] : Refactoring Code and adding shufflereadmetrics data
Jul 1, 2018
6a0622e
[SPARK-21809] : Fixing scalastyle tests
Jul 1, 2018
132fce9
[SPARK-21809] : Fixing Scalastyle test again
Jul 1, 2018
573390d
[SPARK-21809] : Changing comment to point to generic url
Sep 10, 2018
af83b6e
[SPARK-21809] : Addressing Reviews September 14, 2018
Sep 14, 2018
07c1f19
[SPARK-21809] : Doing search on keyup instead of Enter
Sep 17, 2018
cbfbd07
[SPARK-21809] : Addressing Reviews September 23, 2018
Sep 23, 2018
af11138
[SPARK-21809] : Fixing unit test
Sep 24, 2018
20ef5e5
[SPARK-21809] : Addressing Reviews September 25, 2018
Sep 25, 2018
51c0622
[SPARK-21809] : Making executorLogs variable a Scala Option to avoid …
Sep 26, 2018
2e88030
Merge branch 'master' of https://github.com/pgandhi999/spark into SPA…
Sep 26, 2018
b233dad
[SPARK-21809] : Fixing issue of throwing exception with executor summ…
Sep 27, 2018
204c708
[SPARK-21809] : Resolving conflicts wih webui.css
Sep 27, 2018
2bd0fcf
[SPARK-21809] : Fixing scalastyle failures
Sep 27, 2018
a91b306
[SPARK-21809] : Fixing keyup timeout on search not working and pagina…
Sep 28, 2018
930a261
[SPARK-21809] : Fix the length menu dropdown and returning empty tabl…
Oct 1, 2018
2a39374
[SPARK-21809] : Addressing Reviews October 3, 2018
Oct 3, 2018
a1d4317
Merge branch 'master' of https://github.com/pgandhi999/spark into SPA…
Oct 3, 2018
1ba30ce
[SPARK-21809] : Fixing Scalastyle Tests
Oct 3, 2018
8cf0e34
[SPARK-21809] : Fixing Scalastyle Tests in import statement
Oct 3, 2018
a4ed19d
[SPARK-21809] : Addressing Reviews and Bug Fixes October 5, 2018
Oct 5, 2018
3a1f274
[SPARK-21809] : Addressing Reviews October 12, 2018
Oct 12, 2018
7e486f1
[SPARK-21809] : Addressing Reviews October 17, 2018
Oct 17, 2018
a4661fe
[SPARK-21809] : Fixing HistoryServerSuite Unit Tests
Oct 17, 2018
258e81b
[SPARK-21809] : Addressing Reviews October 23, 2018
Oct 23, 2018
052f706
Merge branch 'master' of https://github.com/pgandhi999/spark into SPA…
Oct 23, 2018
0ed3309
[SPARK-21809] : Addressing Reviews October 29, 2018
Oct 29, 2018
66a14bc
[SPARK-21809] : Addressing Reviews November 1, 2018
Nov 1, 2018
24e6b45
[SPARK-21809] : Addressing Reviews November 2, 2018
Nov 2, 2018
c26a9ff
Merge branch 'master' of https://github.com/pgandhi999/spark into SPA…
Nov 5, 2018
a8b5862
[SPARK-21809] : Addressing Reviews November 7, 2018
Nov 7, 2018
d6b41ca
[SPARK-21809] : Addressing Reviews November 8, 2018
Nov 8, 2018
73a5451
[SPARK-21809] : Addressing Reviews November 12, 2018
Nov 12, 2018
271de2d
[SPARK-21809] : Reverting some changes in previous commit
Nov 12, 2018
b438af5
[SPARK-21809] : Adding alert message to users on trying to perform se…
Nov 14, 2018
3111166
[SPARK-21809] : Adding borders to all datatables in stage page and ex…
Nov 19, 2018
a696dcc
Merge branch 'master' of https://github.com/pgandhi999/spark into SPA…
Nov 19, 2018
b3e2370
[SPARK-21809] : Adding pagination feature to event timeline graph
Nov 20, 2018
672b12a
[SPARK-21809] : Addressing Reviews November 20, 2018
Nov 20, 2018
8f6efbd
[SPARK-21809] : Fixing arguments to be multi line style
Nov 20, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
-->

<script id="executors-summary-template" type="text/html">
<h4 style="clear: left; display: inline-block;">Summary</h4>
<h4 class="title-table">Summary</h4>
<div class="container-fluid">
<div class="container-fluid">
<table id="summary-execs-table" class="table table-striped compact">
Expand Down Expand Up @@ -64,7 +64,7 @@ <h4 style="clear: left; display: inline-block;">Summary</h4>
</table>
</div>
</div>
<h4 style="clear: left; display: inline-block;">Executors</h4>
<h4 class="title-table">Executors</h4>
<div class="container-fluid">
<div class="container-fluid">
<table id="active-executors-table" class="table table-striped compact">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,46 +59,6 @@ $(document).ajaxStart(function () {
$.blockUI({message: '<h3>Loading Executors Page...</h3>'});
});

function createTemplateURI(appId) {
var words = document.baseURI.split('/');
var ind = words.indexOf("proxy");
if (ind > 0) {
var baseURI = words.slice(0, ind + 1).join('/') + '/' + appId + '/static/executorspage-template.html';
return baseURI;
}
ind = words.indexOf("history");
if(ind > 0) {
var baseURI = words.slice(0, ind).join('/') + '/static/executorspage-template.html';
return baseURI;
}
return location.origin + "/static/executorspage-template.html";
}

function getStandAloneppId(cb) {
var words = document.baseURI.split('/');
var ind = words.indexOf("proxy");
if (ind > 0) {
var appId = words[ind + 1];
cb(appId);
return;
}
ind = words.indexOf("history");
if (ind > 0) {
var appId = words[ind + 1];
cb(appId);
return;
}
//Looks like Web UI is running in standalone mode
//Let's get application-id using REST End Point
$.getJSON(location.origin + "/api/v1/applications", function(response, status, jqXHR) {
if (response && response.length > 0) {
var appId = response[0].id
cb(appId);
return;
}
});
}

function createRESTEndPoint(appId) {
var words = document.baseURI.split('/');
var ind = words.indexOf("proxy");
Expand All @@ -121,16 +81,6 @@ function createRESTEndPoint(appId) {
return location.origin + "/api/v1/applications/" + appId + "/allexecutors";
}

function formatLogsCells(execLogs, type) {
if (type !== 'display') return Object.keys(execLogs);
if (!execLogs) return;
var result = '';
$.each(execLogs, function (logName, logUrl) {
result += '<div><a href=' + logUrl + '>' + logName + '</a></div>'
});
return result;
}

function logsExist(execs) {
return execs.some(function(exec) {
return !($.isEmptyObject(exec["executorLogs"]));
Expand Down Expand Up @@ -178,15 +128,11 @@ function totalDurationColor(totalGCTime, totalDuration) {
}

$(document).ready(function () {
$.extend($.fn.dataTable.defaults, {
stateSave: true,
lengthMenu: [[20, 40, 60, 100, -1], [20, 40, 60, 100, "All"]],
pageLength: 20
});
setDataTableDefaults();

executorsSummary = $("#active-executors");

getStandAloneppId(function (appId) {
getStandAloneAppId(function (appId) {

var endPoint = createRESTEndPoint(appId);
$.getJSON(endPoint, function (response, status, jqXHR) {
Expand Down Expand Up @@ -408,7 +354,7 @@ $(document).ready(function () {
};

var data = {executors: response, "execSummary": [activeSummary, deadSummary, totalSummary]};
$.get(createTemplateURI(appId), function (template) {
$.get(createTemplateURI(appId, "executorspage"), function (template) {

executorsSummary.append(Mustache.render($(template).filter("#executors-summary-template").html(), data));
var selector = "#active-executors-table";
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading