[MINOR][SQL] Combine the same codes in test cases #23194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch |
|
ok to test |
kiszk
reviewed
Dec 1, 2018
| @@ -37,7 +37,7 @@ import org.apache.spark.internal.Logging | |||
| * tasks was performed by the ShuffleMemoryManager. | |||
| * | |||
| * @param lock a [[MemoryManager]] instance to synchronize on | |||
| * @param memoryMode the type of memory tracked by this pool (on- or off-heap) | |||
| * @param memoryMode the type of memory tracked by this pool (on-heap or off-heap) | |||
There was a problem hiding this comment.
Is this change related to this PR?
There was a problem hiding this comment.
No, I think it can be modified here,so I changed it by the way.
kiszk
reviewed
Dec 1, 2018
| @@ -28,7 +28,7 @@ import org.apache.spark.storage.memory.MemoryStore | |||
| * (caching). | |||
| * | |||
| * @param lock a [[MemoryManager]] instance to synchronize on | |||
| * @param memoryMode the type of memory tracked by this pool (on- or off-heap) | |||
| * @param memoryMode the type of memory tracked by this pool (on-heap or off-heap) | |||
|
Test build #99551 has finished for PR 23194 at commit
|
CarolinePeng
force-pushed
the
Update_temp
branch
from
eff036c
to
126ca0d
Compare
|
Test build #99587 has finished for PR 23194 at commit
|
|
LGTM, cc @HyukjinKwon. |
maropu
reviewed
Dec 3, 2018
| test("CTAS a managed table with the existing empty directory") { | ||
| val tableLoc = new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab1"))) | ||
| try { | ||
| protected def withTableLocation(tableNames: String)(f: File => Unit): Unit = { |
There was a problem hiding this comment.
How about withEmptyDirInTablePath(dirName: String)?
maropu
reviewed
Dec 3, 2018
| protected def withTableLocation(tableNames: String)(f: File => Unit): Unit = { | ||
| val tableLoc = | ||
| new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier(tableNames))) | ||
| try |
maropu
reviewed
Dec 3, 2018
| } | ||
| } | ||
|
|
srowen
approved these changes
Dec 3, 2018
CarolinePeng
force-pushed
the
Update_temp
branch
from
126ca0d
to
867ee5e
Compare
maropu
reviewed
Dec 4, 2018
| @@ -377,41 +377,41 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils { | |||
| } | |||
| } | |||
|
|
|||
| test("CTAS a managed table with the existing empty directory") { | |||
| val tableLoc = new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab1"))) | |||
| protected def withEmptyDirInTablePath(dirName: String)(f: File => Unit): Unit = { | |||
|
LGTM except for minor comments |
CarolinePeng
force-pushed
the
Update_temp
branch
from
867ee5e
to
877751b
Compare
|
Test build #99644 has finished for PR 23194 at commit
|
|
Test build #99649 has finished for PR 23194 at commit
|
CarolinePeng
force-pushed
the
Update_temp
branch
from
877751b
to
ac2b004
Compare
|
Test build #99652 has finished for PR 23194 at commit
|
|
retest this please |
|
Test build #99656 has finished for PR 23194 at commit
|
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? In the DDLSuit, there are four test cases have the same codes , writing a function can combine the same code. ## How was this patch tested? existing tests. Closes apache#23194 from CarolinePeng/Update_temp. Authored-by: 彭灿00244106 <00244106@zte.intra> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the DDLSuit, there are four test cases have the same codes , writing a function can combine the same code.
How was this patch tested?
existing tests.