[SPARK-26289][CORE]cleanup enablePerfMetrics parameter from BytesToBytesMap #23244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan, @maropu, @kiszk |
|
Test build #99760 has finished for PR 23244 at commit
|
cloud-fan
reviewed
Dec 6, 2018
| @@ -209,23 +205,14 @@ public BytesToBytesMap( | |||
| TaskMemoryManager taskMemoryManager, | |||
There was a problem hiding this comment.
If this constructor is called, the enablePerfMetrics will be false. Where do we use this constructor?
There was a problem hiding this comment.
review the current master branch, this constructor is called by HashedRelationSuite , AggregateBenchmark, UnsafeKVExternalSorterSuite, AbstractBytesToBytesMapSuite. thanks.
There was a problem hiding this comment.
OK all tests, then we are fine
|
thanks, merging to master! |
|
thanks, @cloud-fan |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ytesMap ## What changes were proposed in this pull request? `enablePerfMetrics `was originally designed in `BytesToBytesMap `to control `getNumHashCollisions getTimeSpentResizingNs getAverageProbesPerLookup`. However, as the Spark version gradual progress. this parameter is only used for `getAverageProbesPerLookup ` and always given to true when using `BytesToBytesMap`. it is also dangerous to determine whether `getAverageProbesPerLookup `opens and throws an `IllegalStateException `exception. So this pr will be remove `enablePerfMetrics `parameter from `BytesToBytesMap`. thanks. ## How was this patch tested? the existed test cases. Closes apache#23244 from heary-cao/enablePerfMetrics. Authored-by: caoxuewen <cao.xuewen@zte.com.cn> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
enablePerfMetricswas originally designed inBytesToBytesMapto controlgetNumHashCollisions getTimeSpentResizingNs getAverageProbesPerLookup.However, as the Spark version gradual progress. this parameter is only used for
getAverageProbesPerLookupand always given to true when usingBytesToBytesMap.it is also dangerous to determine whether
getAverageProbesPerLookupopens and throws anIllegalStateExceptionexception.So this pr will be remove
enablePerfMetricsparameter fromBytesToBytesMap. thanks.How was this patch tested?
the existed test cases.