Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24207][R] follow-up PR for SPARK-24207 to fix code style problems #23256

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

follow-up PR for SPARK-24207 to fix code style problems

@srowen
Copy link
Member

srowen commented Dec 7, 2018

CC @felixcheung

@SparkQA
Copy link

SparkQA commented Dec 8, 2018

Test build #99843 has finished for PR 23256 at commit 04ec3e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tbh, more meaningful dataset as example would be better...

list(list(list(1L), list(3L)), 2L)),
schema = c("sequence", "freq"))

expect_equivalent(expected_result, result)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an important fix..

@HyukjinKwon
Copy link
Member

Merged to master.

@HyukjinKwon
Copy link
Member

Ooops,

tbh, more meaningful dataset as example would be better...

did you expect to fix more instances here Felix? Sorry, I misread.

@asfgit asfgit closed this in 678e1ac Dec 8, 2018
@felixcheung
Copy link
Member

felixcheung commented Dec 9, 2018

ideally, but really not for this PR
so it's ok

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

follow-up PR for SPARK-24207 to fix code style problems

Closes apache#23256 from huaxingao/spark-24207-cnt.

Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants