-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24207][R] follow-up PR for SPARK-24207 to fix code style problems #23256
Conversation
CC @felixcheung |
Test build #99843 has finished for PR 23256 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. tbh, more meaningful dataset as example would be better...
list(list(list(1L), list(3L)), 2L)), | ||
schema = c("sequence", "freq")) | ||
|
||
expect_equivalent(expected_result, result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an important fix..
Merged to master. |
Ooops,
did you expect to fix more instances here Felix? Sorry, I misread. |
ideally, but really not for this PR |
## What changes were proposed in this pull request? follow-up PR for SPARK-24207 to fix code style problems Closes apache#23256 from huaxingao/spark-24207-cnt. Authored-by: Huaxin Gao <huaxing@us.ibm.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
follow-up PR for SPARK-24207 to fix code style problems