[SPARK-26576][SQL][TEST] Broadcast hint not applied to partitioned table #23530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? Make sure broadcast hint is applied to partitioned tables. ## How was this patch tested? - A new unit test in PruneFileSourcePartitionsSuite - Unit test suites touched by SPARK-14581: JoinOptimizationSuite, FilterPushdownSuite, ColumnPruningSuite, and PruneFiltersSuite Closes apache#23507 from jzhuge/SPARK-26576. Authored-by: John Zhuge <jzhuge@apache.org> Signed-off-by: gatorsmile <gatorsmile@gmail.com> (cherry picked from commit b9eb0e8)
|
ok to test |
| @@ -68,9 +68,6 @@ object PhysicalOperation extends PredicateHelper { | |||
| val substitutedCondition = substitute(aliases)(condition) | |||
| (fields, filters ++ splitConjunctivePredicates(substitutedCondition), other, aliases) | |||
|
|
|||
| case h: ResolvedHint => | |||
| collectProjectsAndFilters(h.child) | |||
|
|
|||
There was a problem hiding this comment.
Hi, @jzhuge .
Do we need to remove this? According to the previous PR, master has no issue. So, I expected a test only PR.
cc @cloud-fan and @gatorsmile
There was a problem hiding this comment.
Yeah, it is safer to only port the unit test. However, I believe this is dead code, otherwise we might have to revisit the fix for 2.4 and 2.3.
There was a problem hiding this comment.
In that case, let's not change this in this PR [SPARK-26576][SQL] Broadcast hint not applied to partitioned table .
For the dead code cleaning up, you can do that later.
|
Test build #101135 has finished for PR 23530 at commit
|
|
Test build #101139 has finished for PR 23530 at commit
|
gatorsmile
reviewed
Jan 13, 2019
gatorsmile
changed the title
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Make sure broadcast hint is applied to partitioned tables. ## How was this patch tested? - A new unit test in PruneFileSourcePartitionsSuite - Unit test suites touched by SPARK-14581: JoinOptimizationSuite, FilterPushdownSuite, ColumnPruningSuite, and PruneFiltersSuite Closes apache#23507 from jzhuge/SPARK-26576. Closes apache#23530 from jzhuge/SPARK-26576-master. Authored-by: John Zhuge <jzhuge@apache.org> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make sure broadcast hint is applied to partitioned tables.
How was this patch tested?
Closes #23507 from jzhuge/SPARK-26576.