Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE][MINOR] Fix some typos about MemoryMode #23533

Closed
wants to merge 1 commit into from
Closed

[CORE][MINOR] Fix some typos about MemoryMode #23533

wants to merge 1 commit into from

Conversation

SongYadong
Copy link
Contributor

What changes were proposed in this pull request?

Fix typos in comments by replacing "in-heap" with "on-heap".

How was this patch tested?

Existing Tests.

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jan 14, 2019

Test build #101165 has finished for PR 23533 at commit 4975d5a.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jan 14, 2019

Test build #101180 has finished for PR 23533 at commit 4975d5a.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 14, 2019

Test build #4513 has started for PR 23533 at commit 4975d5a.

@SparkQA
Copy link

SparkQA commented Jan 15, 2019

Test build #4514 has finished for PR 23533 at commit 4975d5a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in a77505d Jan 15, 2019
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@SongYadong @jackylee-ch
[CORE][MINOR] Fix some typos about MemoryMode
6980e7f 
## What changes were proposed in this pull request?

Fix typos in comments by replacing "in-heap" with "on-heap".

## How was this patch tested?

Existing Tests.

Closes apache#23533 from SongYadong/typos_inheap_to_onheap.

Authored-by: SongYadong <song.yadong1@zte.com.cn>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SongYadong @HyukjinKwon @SparkQA @srowen