Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2066][SQL] Adds checks for non-aggregate attributes with aggregation #2774

Closed
wants to merge 2 commits into from
Closed

[SPARK-2066][SQL] Adds checks for non-aggregate attributes with aggregation #2774

wants to merge 2 commits into from

Conversation

liancheng
Copy link
Contributor

This PR adds a new rule CheckAggregation to the analyzer to provide better error message for non-aggregate attributes with aggregation.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have started for PR 2774 at commit 4428f2c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have finished for PR 2774 at commit 4428f2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21667/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have started for PR 2774 at commit a6ee016.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have finished for PR 2774 at commit a6ee016.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21669/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have started for PR 2774 at commit bf1878d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have finished for PR 2774 at commit bf1878d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21671/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 13, 2014

QA tests have started for PR 2774 at commit 5246004.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 13, 2014

QA tests have finished for PR 2774 at commit 5246004.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21674/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in 56102dc Oct 13, 2014
@liancheng liancheng deleted the non-aggregate-attr branch October 14, 2014 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liancheng @AmplabJenkins @SparkQA @marmbrus