Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32783][DOCS][PYTHON] Development - Testing PySpark #29634

Closed
wants to merge 5 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 3, 2020

What changes were proposed in this pull request?

This PR proposes to add a page to describe how to test PySpark. Note that it avoids duplication of https://spark.apache.org/developer-tools.html and it more aims to add put the relevant links together.

I made a demo site to review more effectively: https://hyukjin-spark.readthedocs.io/en/stable/development/testing.html

Why are the changes needed?

To guide PySpark developers easily test.

Does this PR introduce any user-facing change?

Yes, it will adds a new documentation page.

How was this patch tested?

Manually tested.

@HyukjinKwon
Copy link
Member Author

@srowen, @viirya, @BryanCutler WDYT?

@SparkQA
Copy link

SparkQA commented Sep 3, 2020

Test build #128245 has finished for PR 29634 at commit ee723db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

python/docs/source/development/testing.rst Outdated Show resolved Hide resolved
python/docs/source/development/testing.rst Outdated Show resolved Hide resolved
python/docs/source/development/testing.rst Show resolved Hide resolved
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Sep 4, 2020

Test build #128274 has finished for PR 29634 at commit 46934b3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 4, 2020

Test build #128277 has finished for PR 29634 at commit 9dac672.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Merged to master.

@HyukjinKwon HyukjinKwon deleted the SPARK-32783 branch December 7, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants