Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, external, and examples #30342

Closed
wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 12, 2020

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per @holdenk #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Backport of #30326

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No testing was performed

…nd examples

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk apache#30323 (comment)

NOTE: The misspellings have been reported at 706a726#commitcomment-44064356

Misspelled words make it harder to read / understand content.

No

No testing was performed

Closes apache#30326 from jsoref/spelling-graphx.

Authored-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@maropu maropu changed the title [MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, a… [MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, external, and examples Nov 12, 2020
@maropu
Copy link
Member

maropu commented Nov 12, 2020

ok to test

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Test build #130951 has finished for PR 30342 at commit 64effa1.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35558/

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35558/

@maropu
Copy link
Member

maropu commented Nov 12, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35603/

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35603/

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Test build #130997 has finished for PR 30342 at commit 64effa1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Nov 13, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35645/

@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Test build #131039 has finished for PR 30342 at commit 64effa1.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35645/

@srowen
Copy link
Member

srowen commented Nov 16, 2020

@maropu do you really think we need to backport? that is generally only for bug fixes. It's not a huge deal either way but not sure we should do that in general.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 16, 2020

fwiw, the argument in favor of backporting is that it'll make future backports easier, otherwise any fixes past this point (on master) will be harder to backport (because of the changes made by this work on master).

I'm not arguing in favor/opposed (I have no opinion).

@maropu
Copy link
Member

maropu commented Nov 17, 2020

@maropu do you really think we need to backport? that is generally only for bug fixes. It's not a huge deal either way but not sure we should do that in general.

Ah, I see. I thought its better to fix the user-facing typo, so I requested to backport it. But, I don't have a strong feeling on it. We don't need it in branch-3.0, @srowen ? if not, we need to revert it in branch-2.4.

@srowen
Copy link
Member

srowen commented Nov 17, 2020

Oh I see, already in 2.4. OK go ahead and merge it rather than revert. I don't feel strongly either, just know we don't generally backport anything like this as a rule.

@maropu
Copy link
Member

maropu commented Nov 17, 2020

ok~, thanks for the check, @srowen

@maropu
Copy link
Member

maropu commented Nov 17, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35787/

@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35787/

@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Test build #131185 has finished for PR 30342 at commit 64effa1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

maropu pushed a commit that referenced this pull request Nov 17, 2020
…al, and examples

### What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Backport of #30326

### Why are the changes needed?

Misspelled words make it harder to read / understand content.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No testing was performed

Closes #30342 from jsoref/branch-3.0-30326.

Authored-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@maropu
Copy link
Member

maropu commented Nov 17, 2020

Thanks! Merged to branch-3.0.

@maropu maropu closed this Nov 17, 2020
@jsoref jsoref deleted the branch-3.0-30326 branch November 17, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants