-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, external, and examples #30342
Conversation
…nd examples This PR intends to fix typos in the sub-modules: graphx, external, and examples. Split per holdenk apache#30323 (comment) NOTE: The misspellings have been reported at 706a726#commitcomment-44064356 Misspelled words make it harder to read / understand content. No No testing was performed Closes apache#30326 from jsoref/spelling-graphx. Authored-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
ok to test |
Test build #130951 has finished for PR 30342 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #130997 has finished for PR 30342 at commit
|
retest this please |
Kubernetes integration test starting |
Test build #131039 has finished for PR 30342 at commit
|
Kubernetes integration test status success |
@maropu do you really think we need to backport? that is generally only for bug fixes. It's not a huge deal either way but not sure we should do that in general. |
fwiw, the argument in favor of backporting is that it'll make future backports easier, otherwise any fixes past this point (on master) will be harder to backport (because of the changes made by this work on master). I'm not arguing in favor/opposed (I have no opinion). |
Ah, I see. I thought its better to fix the user-facing typo, so I requested to backport it. But, I don't have a strong feeling on it. We don't need it in branch-3.0, @srowen ? if not, we need to revert it in branch-2.4. |
Oh I see, already in 2.4. OK go ahead and merge it rather than revert. I don't feel strongly either, just know we don't generally backport anything like this as a rule. |
ok~, thanks for the check, @srowen |
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #131185 has finished for PR 30342 at commit
|
…al, and examples ### What changes were proposed in this pull request? This PR intends to fix typos in the sub-modules: graphx, external, and examples. Split per holdenk #30323 (comment) NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356 Backport of #30326 ### Why are the changes needed? Misspelled words make it harder to read / understand content. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No testing was performed Closes #30342 from jsoref/branch-3.0-30326. Authored-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Thanks! Merged to branch-3.0. |
What changes were proposed in this pull request?
This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per @holdenk #30323 (comment)
NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356
Backport of #30326
Why are the changes needed?
Misspelled words make it harder to read / understand content.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No testing was performed