[SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark #30476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
approved these changes
Nov 24, 2020
| ------------------------------------------------------------------------------------------------------------------------- | ||
| subexpressionElimination off, codegen on 42687 42805 111 0.0 426873372.5 1.0X | ||
| subexpressionElimination off, codegen off 43606 45108 1613 0.0 436055236.3 1.0X | ||
| subexpressionElimination on, codegen on 29761 30563 704 0.0 297614324.4 1.4X |
There was a problem hiding this comment.
In this case, do we have only 40% improvement?
There was a problem hiding this comment.
Seems so, it is subexpression elimination under codegen.
There was a problem hiding this comment.
I will submit subexpression elimination under non-codegen after this.
dongjoon-hyun
approved these changes
Nov 24, 2020
This comment has been minimized.
This comment has been minimized.
|
retest this please |
HyukjinKwon
reviewed
Nov 24, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
Nov 24, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala
Outdated
Show resolved
Hide resolved
|
GA passed. |
|
Thanks @HyukjinKwon @dongjoon-hyun @maropu |
|
Test build #131615 has finished for PR 30476 at commit
|
|
Test build #131618 has finished for PR 30476 at commit
|
|
Test build #131613 has finished for PR 30476 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds predicate related benchmark to
SubExprEliminationBenchmark.Why are the changes needed?
We should have a benchmark for subexpression elimination of predicate.
Does this PR introduce any user-facing change?
No, dev only.
How was this patch tested?
Run benchmark locally.