-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32670][SQL][FOLLOWUP] Group exception messages in Catalyst Analyzer in one file #30564
Conversation
Kubernetes integration test status success |
Test build #132407 has finished for PR 30564 at commit
|
retest this please |
Test build #132425 has finished for PR 30564 at commit
|
retest this please |
Test build #132433 has finished for PR 30564 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
The hive thrift server tests seem to have issues: |
retest this please |
Kubernetes integration test starting |
Test build #132465 has finished for PR 30564 at commit
|
def expressionWithMultiWindowExpressionsError( | ||
expr: NamedExpression, distinctWindowSpec: Seq[WindowSpecDefinition]): Throwable = { | ||
new AnalysisException(s"$expr has multiple Window Specifications ($distinctWindowSpec)." + | ||
s"Please file a bug report with this error message, stack trace, and the query.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
def windowFunctionWithWindowFrameNotOrderedError(wf: WindowFunction): Throwable = { | ||
new AnalysisException(s"Window function $wf requires window to be ordered, please add " + | ||
s"ORDER BY clause. For example SELECT $wf(value_expr) OVER (PARTITION BY window_partition " + | ||
s"ORDER BY window_ordering) from table") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove s
|
||
def writeTableWithMismatchedColumnsError( | ||
columnSize: Int, outputSize: Int, t: TreeNode[_]): Throwable = { | ||
new AnalysisException(s"Cannot write to table due to mismatched user specified column " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove s
Kubernetes integration test status success |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #132472 has finished for PR 30564 at commit
|
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #132486 has finished for PR 30564 at commit
|
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #132527 has finished for PR 30564 at commit
|
thanks, merging to master! |
@cloud-fan Thanks for your work! |
What changes were proposed in this pull request?
This PR follows up #29497.
Because #29497 just give us an example to group all
AnalysisExcpetion
in Analyzer into QueryCompilationErrors.This PR group other
AnalysisExcpetion
into QueryCompilationErrors.Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.