-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2 #30690
Conversation
Yey! Thanks, @viirya . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, we already support ARM64, don't we? We have ARM64 Jenkins job for a long time.
Support Apple Silicon (M1, Mac-aarch64)
As this is minor upgrade and fixes a few bugs, seems okay to backport to branch-3.1 too. cc @dongjoon-hyun @HyukjinKwon |
I guess so. But I am not sure if there is any difference between Apple Silicon and ARM64. |
@viirya . For the bug fixes, we may need to land this to all live branches (master/branch-3.1/branch-3.2/branch-2.4) if that is true.
Please see the symptom of the new Mac on the PR description. |
As I checked snappy-java's Makefile, the original ARM64 support is only for Linux-aarch64 before. |
Thanks. I converted SPARK-33725 from |
Thanks @dongjoon-hyun ! |
Kubernetes integration test starting |
Kubernetes integration test status success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
There is a conflict at branch-3.1. Could you make a backporting PR to old release branches? |
Yea, thanks @dongjoon-hyun. |
Test build #132512 has finished for PR 30690 at commit
|
lgtm |
…py-java version to 1.1.8.4 (#1198) * [CARMEL-6489][SPARK-33205][BUILD] Bump snappy-java version to 1.1.8 Backport #30120 * [CARMEL-6489][SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2 Backport #30690 * [CARMEL-6489][SPARK-35277][BUILD] Upgrade snappy to 1.1.8.4 Backport #32402
What changes were proposed in this pull request?
This upgrades snappy-java to 1.1.8.2.
Why are the changes needed?
Minor version upgrade that includes:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test.