Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-33727][K8S] Fall back from gnupg.net to openpgp.org #30696

Closed
wants to merge 1 commit into from
Closed

[SPARK-33727][K8S] Fall back from gnupg.net to openpgp.org #30696

wants to merge 1 commit into from

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Dec 10, 2020

What changes were proposed in this pull request?

While building R docker image if we can't fetch the key from gnupg.net fall back to openpgp.org

Why are the changes needed?

gnupg.net key servers are flaky and sometimes fail to resolve or return keys.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tried to add key on my desktop, it failed, then tried to add key with openpgp.org and it succeed.

@holdenk
Copy link
Contributor Author

holdenk commented Dec 10, 2020

cc @shaneknapp

@holdenk
Copy link
Contributor Author

holdenk commented Dec 10, 2020

We'll see if this passes in Jenkins :)

@SparkQA
Copy link

SparkQA commented Dec 10, 2020

Test build #132523 has finished for PR 30696 at commit 9696520.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 10, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37126/

@HyukjinKwon
Copy link
Member

@holdenk, hey fortunately I have my env to test :-) I am facing exactly the same issue. I will test and come back soon.

@SparkQA
Copy link

SparkQA commented Dec 10, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37126/

dongjoon-hyun
dongjoon-hyun approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks, @holdenk .

@dongjoon-hyun
Copy link
Member

The Jenkins K8s IT passed the docker image building. The failure is irrelevant to this PR.

- Run in client mode. *** FAILED ***

@dongjoon-hyun
Copy link
Member

BTW, I'll leave this PR to @HyukjinKwon since he is able to double-checking this. Thanks, @HyukjinKwon .

HyukjinKwon
HyukjinKwon approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it works now

@HyukjinKwon
Copy link
Member

Merged to master, branch-3.1 and branch-3.0.

HyukjinKwon pushed a commit that referenced this pull request Dec 10, 2020
@holdenk @HyukjinKwon
[SPARK-33727][K8S] Fall back from gnupg.net to openpgp.org
db4cbfc 
### What changes were proposed in this pull request?

While building R docker image if we can't fetch the key from gnupg.net fall back to openpgp.org

### Why are the changes needed?

gnupg.net key servers are flaky and sometimes fail to resolve or return keys.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Tried to add key on my desktop, it failed, then tried to add key with openpgp.org and it succeed.

Closes #30696 from holdenk/SPARK-33727-gnupg-server-is-flaky.

Authored-by: Holden Karau <hkarau@apple.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 991b797)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

Thanks for addressing this issue guys!

HyukjinKwon pushed a commit that referenced this pull request Dec 10, 2020
@holdenk @HyukjinKwon
[SPARK-33727][K8S] Fall back from gnupg.net to openpgp.org
a4c5e54 
### What changes were proposed in this pull request?

While building R docker image if we can't fetch the key from gnupg.net fall back to openpgp.org

### Why are the changes needed?

gnupg.net key servers are flaky and sometimes fail to resolve or return keys.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Tried to add key on my desktop, it failed, then tried to add key with openpgp.org and it succeed.

Closes #30696 from holdenk/SPARK-33727-gnupg-server-is-flaky.

Authored-by: Holden Karau <hkarau@apple.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 991b797)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
KUBERNETES R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holdenk @SparkQA @HyukjinKwon @dongjoon-hyun