[SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout #31166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngone51
approved these changes
Jan 13, 2021
| @@ -49,7 +49,7 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS | |||
| .set(config.DECOMMISSION_ENABLED, true) | |||
| .set(config.STORAGE_DECOMMISSION_ENABLED, isEnabled) | |||
| sc = new SparkContext(conf) | |||
| TestUtils.waitUntilExecutorsUp(sc, 2, 6000) | |||
| TestUtils.waitUntilExecutorsUp(sc, 2, 60000) | |||
There was a problem hiding this comment.
Oops..I wondered why it's flaky at this place and thought it was already 60s....
There was a problem hiding this comment.
ah, I guess it's a typo : )
HyukjinKwon
approved these changes
Jan 13, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Merged to master and branch-3.1. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 13, 2021
### What changes were proposed in this pull request? Increase test timeout. ### Why are the changes needed? It's more reasonable to use 60s instead of 6s since many code place use the 60s in `TestUtils.waitUntilExecutorsUp`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass exists test. Closes #31166 from ulysses-you/SPARK-32850-FOLLOWUP. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit f64297d) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Test build #134001 has finished for PR 31166 at commit
|
|
thanks for merging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increase test timeout.
Why are the changes needed?
It's more reasonable to use 60s instead of 6s since many code place use the 60s in
TestUtils.waitUntilExecutorsUp.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass exists test.