Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33354][FOLLOWUP][DOC] Shorten the table width of ANSI compliance casting document #31180

Closed

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

This is a follow-up of #30260
It shortens the table width of ANSI compliance casting document.

Why are the changes needed?

The table is too wide and the UI of doc site is broken if we scroll the page to right side.
Screen Shot 2021-01-14 at 3 04 57 PM

Does this PR introduce any user-facing change?

Minor document change

How was this patch tested?

Build doc site locally and preview:
Screen Shot 2021-01-14 at 4 44 30 PM

@gengliangwang
Copy link
Member Author

cc @maropu @HyukjinKwon
It's minor but I want to make sure the ANSI doc looks fine

@github-actions github-actions bot added the DOCS label Jan 14, 2021
@SparkQA
Copy link

SparkQA commented Jan 14, 2021

Test build #134047 has finished for PR 31180 at commit 9fe059c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun pushed a commit that referenced this pull request Jan 14, 2021
…ce casting document

### What changes were proposed in this pull request?

This is a follow-up of #30260
It shortens the table width of ANSI compliance casting document.

### Why are the changes needed?

The table is too wide and the UI of doc site is broken if we scroll the page to right side.
![Screen Shot 2021-01-14 at 3 04 57 PM](https://user-images.githubusercontent.com/1097932/104565897-d2693b80-5601-11eb-9f93-5f603cfc94c1.png)

### Does this PR introduce _any_ user-facing change?

Minor document change

### How was this patch tested?

Build doc site locally and preview:
![Screen Shot 2021-01-14 at 4 44 30 PM](https://user-images.githubusercontent.com/1097932/104565814-b2d21300-5601-11eb-94c4-78c785cda8ed.png)

Closes #31180 from gengliangwang/reviseAnsiDocStyle.

Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit feedd1b)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
xuanyuanking pushed a commit to xuanyuanking/spark that referenced this pull request Sep 29, 2021
…ce casting document

### What changes were proposed in this pull request?

This is a follow-up of apache#30260
It shortens the table width of ANSI compliance casting document.

### Why are the changes needed?

The table is too wide and the UI of doc site is broken if we scroll the page to right side.
![Screen Shot 2021-01-14 at 3 04 57 PM](https://user-images.githubusercontent.com/1097932/104565897-d2693b80-5601-11eb-9f93-5f603cfc94c1.png)

### Does this PR introduce _any_ user-facing change?

Minor document change

### How was this patch tested?

Build doc site locally and preview:
![Screen Shot 2021-01-14 at 4 44 30 PM](https://user-images.githubusercontent.com/1097932/104565814-b2d21300-5601-11eb-94c4-78c785cda8ed.png)

Closes apache#31180 from gengliangwang/reviseAnsiDocStyle.

Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants