[SPARK-38321][SQL][TESTS] Fix BooleanSimplificationSuite under ANSI #35654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Feb 25, 2022
| ('a > 1 || 'b > 3) && (('a > 1 || 'b > 3) && 'd > 0 && (('a > 1 || 'b > 3) && 'c > 1)), | ||
| ('a > 1 || 'b > 3) && 'd > 0 && 'c > 1) | ||
| ('a > 1 || 'b > 3) && (('a > 1 || 'b > 3) && 'd > 0L && (('a > 1 || 'b > 3) && 'c > 1)), | ||
| ('a > 1 || 'b > 3) && 'd > 0L && 'c > 1) |
There was a problem hiding this comment.
Hm. how did this trigger casting? Seems like all IntegerType.
There was a problem hiding this comment.
ANSI mode would cast the d(string) and 0 to long type. @gengliangwang for more context.
HyukjinKwon
changed the title
|
Can one of the admins verify this patch? |
gengliangwang
approved these changes
Feb 28, 2022
|
Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes BooleanSimplificationSuite under ANSI mode. Change the test case to be a long type to avoid casting difference in ANSI on/off.
Why are the changes needed?
To set up a new GA job to run tests with ANSI mode before 3.3.0 release.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test locally with both ANSI on and off, both passed.