[SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1 #41937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to address the #41933 issue, the above PR has been reverted and now resubmitted. |
|
Recheck this upgrade will not change the generated files. |
HyukjinKwon
approved these changes
Jul 12, 2023
zhengruifeng
approved these changes
Jul 12, 2023
|
merged to master |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? The pr aims to upgrade buf from 1.20.0 to 1.23.1 ### Why are the changes needed? 1.Release Notes: - https://github.com/bufbuild/buf/releases/tag/v1.23.1 - https://github.com/bufbuild/buf/releases/tag/v1.23.0 - https://github.com/bufbuild/buf/releases/tag/v1.22.0 - https://github.com/bufbuild/buf/releases/tag/v1.21.0 2.The new version brings some bug fixed and improvment, as follow: - Fix issue where buf beta graph would not print modules within a workspace that had no dependencies or dependents. - Fix issue where buf beta graph would print warnings for missing dependencies that were actually present. - Fix issue where locally-produced images did not have module information if the corresponding module was stored in the new cache. - Remove buf beta registry template. - Remove buf beta registry plugin {create,deprecate,list,undeprecate,version} and replace with buf beta registry plugin {push,delete}. - Update buf beta price with the latest pricing information. 3.Manually test: dev/connect-gen-protos.sh, this upgrade will not change the generated files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test - Pass GA Closes apache#41937 from panbingkun/SPARK-43974_Right. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade buf from 1.20.0 to 1.23.1
Why are the changes needed?
1.Release Notes:
2.The new version brings some bug fixed and improvment, as follow:
had no dependencies or dependents.
that were actually present.
module was stored in the new cache.
buf beta registry plugin {push,delete}.
3.Manually test: dev/connect-gen-protos.sh, this upgrade will not change the generated files.
Does this PR introduce any user-facing change?
No.
How was this patch tested?