-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7328] [MLlib] [PySpark] Pyspark.mllib.linalg.Vectors: Missing items #5872
Conversation
Merged build triggered. |
Merged build started. |
ping @jkbradley @mengxr Please have a look! |
Test build #31699 has started for PR 5872 at commit |
686b0de
to
350aec7
Compare
Merged build triggered. |
Merged build started. |
Test build #31701 has started for PR 5872 at commit |
Test build #31701 has finished for PR 5872 at commit
|
Merged build finished. Test FAILed. |
Test FAILed. |
Test build #31699 has finished for PR 5872 at commit
|
Merged build finished. Test FAILed. |
Test FAILed. |
350aec7
to
59909f9
Compare
Merged build triggered. |
Merged build started. |
Test build #31707 has started for PR 5872 at commit |
Test build #31707 has finished for PR 5872 at commit
|
Merged build finished. Test PASSed. |
Test PASSed. |
@mengxr Sorry for spaming but could you have a look at this too? My exams start this Friday and hence would like to complete the linalg module at least by then. |
I'll take a look now |
6.0 | ||
""" | ||
if p == 1: | ||
return np.sum(np.abs(self.array)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use numpy.linalg.norm(self.array, p)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
I just accidentally sent some comments, but I'm not done yet |
Merged build started. |
Test build #32133 has started for PR 5872 at commit |
9bd269d
to
a8ff1e0
Compare
@jkbradley fixed! |
Merged build triggered. |
Merged build started. |
Test build #32135 has started for PR 5872 at commit |
Test build #32135 has finished for PR 5872 at commit
|
Merged build finished. Test FAILed. |
Test FAILed. |
test this please |
Merged build triggered. |
Merged build started. |
Test build #32143 has started for PR 5872 at commit |
Test build #32133 has finished for PR 5872 at commit
|
Merged build finished. Test PASSed. |
Test PASSed. |
LGTM Merging into master and branch-1.4 Thanks! |
…items Add 1. Class methods squared_dist 3. parse 4. norm 5. numNonzeros 6. copy I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (#5775) and plan to complete support for Matrices in another PR. Author: MechCoder <manojkumarsivaraj334@gmail.com> Closes #5872 from MechCoder/local_linalg_api and squashes the following commits: a8ff1e0 [MechCoder] minor ce3e53e [MechCoder] Add error message for parser 1bd3c04 [MechCoder] Robust parser and removed unnecessary methods f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items (cherry picked from commit 347a329) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Thanks! I have my exams from 8th to 18th. So will be away for a while, trying to study for those.. Just a heads up! |
OK, good luck with them! |
Test build #32143 timed out for PR 5872 at commit |
Merged build finished. Test FAILed. |
Test FAILed. |
…items Add 1. Class methods squared_dist 3. parse 4. norm 5. numNonzeros 6. copy I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR. Author: MechCoder <manojkumarsivaraj334@gmail.com> Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits: a8ff1e0 [MechCoder] minor ce3e53e [MechCoder] Add error message for parser 1bd3c04 [MechCoder] Robust parser and removed unnecessary methods f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
…items Add 1. Class methods squared_dist 3. parse 4. norm 5. numNonzeros 6. copy I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR. Author: MechCoder <manojkumarsivaraj334@gmail.com> Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits: a8ff1e0 [MechCoder] minor ce3e53e [MechCoder] Add error message for parser 1bd3c04 [MechCoder] Robust parser and removed unnecessary methods f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
…items Add 1. Class methods squared_dist 3. parse 4. norm 5. numNonzeros 6. copy I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR. Author: MechCoder <manojkumarsivaraj334@gmail.com> Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits: a8ff1e0 [MechCoder] minor ce3e53e [MechCoder] Add error message for parser 1bd3c04 [MechCoder] Robust parser and removed unnecessary methods f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
Add
I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (#5775) and plan to complete support for Matrices in another PR.