-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5913] [MLLIB] Python API for ChiSqSelector #5939
Conversation
Merged build triggered. |
Merged build started. |
Test build #31973 has started for PR 5939 at commit |
Test build #31973 has finished for PR 5939 at commit
|
Merged build finished. Test PASSed. |
Test PASSed. |
I'll take a look now |
I don't see any issues except for documentation. Could you please make the Python docs match the Scala ones? (We've been lazy about keeping them in synch, but I want to push for Python doc parity.) Thanks! As a follow up PR, we can finally add a Python code example to the programming guide! |
Oh, also, can you please update the PR description with more details? Feel free to copy from the JIRA. |
@jkbradley , I think the Python docs for ChiSqSelector and ChiSqSelectorModel have reached parity with Scala ones. Please correct me is I misunderstand. |
@yanboliang Sorry, I just assumed the Scala doc had more content. I'll make that a to-do for later. In this case, LGTM! For the API check, we're gradually putting together a list of the many items under this umbrella: [https://issues.apache.org/jira/browse/SPARK-7443] Merging into master and branch-1.4 |
Hm, the merge script complains that this is not mergeable currently. I'll re-run the tests |
Test build #788 has started for PR 5939 at commit |
Test build #788 has finished for PR 5939 at commit
|
Weird, I'll investigate |
Add a Python API for mllib.feature.ChiSqSelector https://issues.apache.org/jira/browse/SPARK-5913 Author: Yanbo Liang <ybliang8@gmail.com> Closes #5939 from yanboliang/spark-5913 and squashes the following commits: cdaac99 [Yanbo Liang] Python API for ChiSqSelector (cherry picked from commit 35c9599) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
It worked this time. Thanks! |
Add a Python API for mllib.feature.ChiSqSelector https://issues.apache.org/jira/browse/SPARK-5913 Author: Yanbo Liang <ybliang8@gmail.com> Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits: cdaac99 [Yanbo Liang] Python API for ChiSqSelector
Add a Python API for mllib.feature.ChiSqSelector https://issues.apache.org/jira/browse/SPARK-5913 Author: Yanbo Liang <ybliang8@gmail.com> Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits: cdaac99 [Yanbo Liang] Python API for ChiSqSelector
Add a Python API for mllib.feature.ChiSqSelector https://issues.apache.org/jira/browse/SPARK-5913 Author: Yanbo Liang <ybliang8@gmail.com> Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits: cdaac99 [Yanbo Liang] Python API for ChiSqSelector
Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913