Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade sccache version to 0.7.* #16366

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Jan 8, 2024

Sccache was previously pinned at version 0.3.3, however, there has recently been an issue when installing some of its dependencies:

error[E0277]: expected a `Fn(reqwest::Request, &'a mut task_local_extensions::extensions::Extensions, reqwest_middleware::Next<'a>)` closure, found `RetryAfterMiddleware`

Upgrading the version of sccache to the latest seems to resolve this error.

In addition, the JFrog artifactory link for boost has been flaky recently, so changing to an alternative
mirror suggested in boostorg/boost#842.

Sccache was previously pinned at version 0.3.3, however, there has
recently been an issue when installing some of its dependencies:

```
error[E0277]: expected a `Fn(reqwest::Request, &'a mut task_local_extensions::extensions::Extensions, reqwest_middleware::Next<'a>)` closure, found `RetryAfterMiddleware`
```

Upgrading the version of sccache to the latest seems to resolve this
error.

Change-Id: Ie292c1189de2ed8464fe1b78e672d7f53a083dff
The JFrog artifactory link is down, so changing to an alternative
mirror mentioned in boostorg/boost#842.

Change-Id: Id83c97d6506dd388ba76b5b01576860844080fa9
@lhutton1
Copy link
Contributor Author

lhutton1 commented Jan 9, 2024

@tvm-bot rerun

@lhutton1 lhutton1 marked this pull request as ready for review January 10, 2024 15:32
@Mousius Mousius merged commit 3166366 into apache:main Jan 10, 2024
20 checks passed
@lhutton1 lhutton1 deleted the fix-sccache-build branch January 10, 2024 15:48
@yongwww
Copy link
Member

yongwww commented Jan 23, 2024

The s3 authentication happens during the sccache --start_server for sccache 0.7.x, the ci build will fail with this upgrade,
test to produce the ci issue with images (sccache 0.7+):
docker/bash.sh --env CI --env PLATFORM --env TVM_SHARD_INDEX --env TVM_NUM_SHARDS --env RUN_DISPLAY_URL --env PLATFORM --env SKIP_SLOW_TESTS --env TEST_STEP_NAME --env NVIDIA_DISABLE_REQUIRE=true --env CI_NUM_EXECUTORS tlcpackstaging/ci_cpu:20240111-070205-0b2358c2e ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod --build-dir build
Looks we will have to provide SCCACHE_BUCKET, SCCACHE_REGION, and aws credential AWS_PROFILE (or AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_SESSION_TOKEN) based on the sccache s3 doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants