Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding URLs to the datapath #372

Closed
reckart opened this issue Aug 14, 2024 · 0 comments
Closed

Allow adding URLs to the datapath #372

reckart opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
⭐️ Enhancement Improvement or new feature for users
Milestone

Comments

@reckart
Copy link
Member

reckart commented Aug 14, 2024

Is your feature request related to a problem? Please describe.
It is possible to add paths via file objects or strings. Internally, they are converted to URLs. But it is not possible add URLs directly to the datapath, e.g. JAR URLs.

Describe the solution you'd like
I would like to be able to add any URL to the datapath given that the resource manager internally manages everything as URLs anyway.

Describe alternatives you've considered
It might be considered to allow adding additional kinds of resources like JAR files or such.

It would also be possible to use an aggregate classloader instead and make resources available through that. However, that classloader would then also always be used to load extension classes and we might want keep loading extension classes (executable-code) and (data) resources separate from each other.

@reckart reckart added the ⭐️ Enhancement Improvement or new feature for users label Aug 14, 2024
@reckart reckart added this to the 3.6.0 milestone Aug 14, 2024
@reckart reckart self-assigned this Aug 14, 2024
reckart added a commit that referenced this issue Aug 14, 2024
- Added methods to set the datapath using URLs
- Added support for URLs to the setDataPathElements(String...) method
- Deprecated methods that return the datapath in a way that is not URLs
- Added more unit tests
- Cleaning up code a bit
reckart added a commit that referenced this issue Aug 15, 2024
- Added methods to set the datapath using URLs
- Added support for URLs to the setDataPathElements(String...) method
- Deprecated methods that return the datapath in a way that is not URLs
- Added more unit tests
- Cleaning up code a bit
reckart added a commit that referenced this issue Aug 15, 2024
…the-datapath

#372 - Allow adding URLs to the datapath
@reckart reckart closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement Improvement or new feature for users
Projects
None yet
Development

No branches or pull requests

1 participant