Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 #4751

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

flowy0
Copy link
Contributor

@flowy0 flowy0 commented Apr 8, 2024

What is this PR for?

To fix the Dockerfile for Zeppelin Server for branch-0.11. The JAVA_HOME variable was set to Java 8, while openjdk11 is being installed.
This issue is already fixed in the master branch.

What type of PR is it?

Bug Fix

Please leave your type of PR only

Todos

  • - Fix JAVA_HOME variable in scripts/docker/zeppelin-server/Dockerfile

What is the Jira issue?

How should this be tested?

  • Strongly recommended: add automated unit tests for any new or changed behavior
  • Outline any manual steps to test the PR here
    • Not too sure how to automate this testing as i'm new at this.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@Reamer Reamer merged commit 3e4bbfd into apache:branch-0.11 Apr 8, 2024
1 check was pending
@jongyoul
Copy link
Member

jongyoul commented Apr 8, 2024

Helo, thank you for the contribution. Could you please make the same one for master branch?

@Reamer
Copy link
Contributor

Reamer commented Apr 8, 2024

Helo, thank you for the contribution. Could you please make the same one for master branch?

Already fixed in master 0f366d8

@jongyoul
Copy link
Member

jongyoul commented Apr 8, 2024

Wow! I was in a different place of

JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \

Could you please fix the line as well?

@jongyoul
Copy link
Member

jongyoul commented Apr 8, 2024

@flowy0
Copy link
Contributor Author

flowy0 commented Apr 8, 2024

Wow! I was in a different place of

JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \

Could you please fix the line as well?

Seems like this file is installing and using JDK8?

@jongyoul
Copy link
Member

jongyoul commented Apr 8, 2024

Yes, this also should use java 11

@flowy0
Copy link
Contributor Author

flowy0 commented Apr 8, 2024

Yes, this also should use java 11

Alright, I'll create another PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants