Introduce dedicated exit codes #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
requested review from
shonfeder,
rodrigo7491,
Kukovec and
konnov
as code owners
konnov
approved these changes
May 13, 2022
thpani
changed the title
shonfeder
suggested changes
May 16, 2022
mod-infra/src/main/scala/at/forsyte/apalache/infra/ExitCodes.scala
Outdated
Show resolved
Hide resolved
mod-infra/src/main/scala/at/forsyte/apalache/infra/ExitCodes.scala
Outdated
Show resolved
Hide resolved
mod-infra/src/main/scala/at/forsyte/apalache/infra/passes/PassChainExecutor.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Shon Feder <shon@informal.systems>
Introduces the new return type PassResult = Either[TExitCode, TlaModule]. A pass returns either an exit code as Left(42) or the resulting TlaModule as Right(module). Co-authored-by: Shon Feder <shon@informal.systems>
Co-authored-by: Shon Feder <shon@informal.systems>
thpani
force-pushed
the
th/typecheck-exitcode
branch
from
da3da08
to
5bd325b
Compare
Codecov Report
@@ Coverage Diff @@
## unstable #1749 +/- ##
============================================
+ Coverage 76.82% 76.89% +0.07%
============================================
Files 379 379
Lines 11826 11824 -2
Branches 570 549 -21
============================================
+ Hits 9085 9092 +7
+ Misses 2741 2732 -9
Continue to review full report at Codecov.
|
This was referenced May 19, 2022
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1392
Exit with dedicated error codes for
To this extent, we:
120(the range 80–149 is unused by TLC) for type-checking errors.Passand its implementations to return anEitherencapsulating the exit code or pass result.Tests added for any new codemake fmt-fix(or had formatting run automatically on all files edited)Documentation added for any new functionality