Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug in type checking uninterpreted types #1792

Merged
merged 3 commits into from
May 20, 2022
Merged

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented May 20, 2022

This PR fixed a bug in uninterpreted types.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Entry added to UNRELEASED.md for any new functionality

@konnov konnov marked this pull request as ready for review May 20, 2022 15:30
@konnov konnov enabled auto-merge May 20, 2022 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #1792 (8b3b2a7) into unstable (4f7cb4c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           unstable    #1792      +/-   ##
============================================
+ Coverage     76.83%   76.85%   +0.01%     
============================================
  Files           383      383              
  Lines         11826    11831       +5     
  Branches        561      571      +10     
============================================
+ Hits           9087     9093       +6     
+ Misses         2739     2738       -1     
Impacted Files Coverage Δ
...yte/apalache/tla/typecheck/ModelValueHandler.scala 100.00% <100.00%> (ø)
...forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala 94.83% <100.00%> (+0.05%) ⬆️
...he/io/annotations/parser/CommentPreprocessor.scala 96.70% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7cb4c...8b3b2a7. Read the comment docs.

@konnov konnov merged commit 15bdd94 into unstable May 20, 2022
@apalache-bot apalache-bot mentioned this pull request May 20, 2022
@shonfeder shonfeder deleted the ik/untyped-error branch July 21, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants