2181/followup refactor #2194
Closed
2181/followup refactor #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
See #2186 (comment) for some info on the failing tests. |
added 3 commits
October 5, 2022 09:48
Adressing PR comments
shonfeder
force-pushed
the
2181/followup-refactor
branch
from
4362e16
to
06c4672
Compare
|
Too stale to be useful at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2186, this sketches some refactoring that may improve code organization and eliminate needless conversions of state.
Along the way I hit some strange behavior and cruft in the tests for the counter example writers, which will need further investigation. But this work will need some prioritization, as it's not clear what immediate value or need we'll have here.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality