Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the mdbook in CI #409

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Build the mdbook in CI #409

merged 1 commit into from
Jan 8, 2021

Conversation

shonfeder
Copy link
Contributor

Ensures that we have a properly compileable book before we allow merging
into CI.

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entry added to CHANGES.md for any new functionality

@shonfeder
Build the mdbook in CI
3702f31 
Ensures that we have a properly compileable book before we allow merging
into CI.
@shonfeder shonfeder requested a review from konnov January 8, 2021 14:26
@shonfeder shonfeder mentioned this pull request Jan 8, 2021
Closed
konnov
konnov approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shonfeder shonfeder merged commit 7803e76 into unstable Jan 8, 2021
@shonfeder shonfeder deleted the shon/compile-mdbook-in-ci-build branch January 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konnov konnov konnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shonfeder @konnov