Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra dependencies for apel ssm service #372

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Sae126V
Copy link
Member

@Sae126V Sae126V commented Sep 18, 2024

  • Remove python3-daemon dependency from the base package. And, add python3-daemon for apel-ssm-service as it is required.

Resolves #371
Resolves GT-555

When installing the service: Now python3-daemon will be installed as part of the service.
Installing:
apel-ssm-service noarch 3.4.1-1.el9 @commandline 13 k
Installing dependencies:
python3-daemon noarch 2.3.2-1.el9 epel 46 k

@Sae126V Sae126V marked this pull request as ready for review September 18, 2024 16:13
@Sae126V Sae126V requested a review from a team as a code owner September 18, 2024 16:13
@tofu-rocketry tofu-rocketry self-assigned this Sep 19, 2024
@tofu-rocketry tofu-rocketry added this to the 4.0.0 milestone Sep 19, 2024
@Sae126V
Copy link
Member Author

Sae126V commented Sep 19, 2024

I have added python3-dirq to 8909fc3 for apel-ssm-service. Does this make sense ? @tofu-rocketry @gregcorbett

@Sae126V Sae126V changed the title Add python3-daemon dependency for apel ssm service Add extra dependencies for apel ssm service Sep 19, 2024
@tofu-rocketry
Copy link
Member

I have added python3-dirq to 8909fc3 for apel-ssm-service. Does this make sense ? @tofu-rocketry @gregcorbett

Yeah, that makes some sense if we're requiring the daemon for the receiving service - the receiver has to use dirq when receiving as that's what the APEL loader then expects to find.

The non-dirq sending is a convenience for non-APEL client sites who just want to dump files into a directory for sending without worrying about the dirq naming schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Change dependency on daemon package
2 participants