fix(validate-types): resolve attr type changed to number when is bigint

apideck-io · Oct 5, 2023 · d0bb431 · d0bb431
1 parent 90f7013
commit d0bb431
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/__tests__/validateTypes.unit.test.ts b/src/__tests__/validateTypes.unit.test.ts
@@ -169,13 +169,16 @@ describe('validateTypes', () => {
   })
 
   it('converts arrays of bigints to sets', async () => {
-    const result = validateTypes()({ type: 'set', setType: 'bigint' }, 'attr', [
+    const attr = { type: 'set', setType: 'bigint' }
+    const result = validateTypes()(attr, 'attr', [
       BigInt(-1234),
       BigInt('123000000000000000000001')
     ])
     expect(result).toEqual(new Set([
       toDynamoBigInt(BigInt(-1234)),
       toDynamoBigInt(BigInt('123000000000000000000001'))
     ]))
+    // Should not mutate the attribute
+    expect(attr.setType).toEqual('bigint')
   })
 })
diff --git a/src/lib/validateTypes.ts b/src/lib/validateTypes.ts
@@ -61,7 +61,6 @@ export default () => (mapping: any, field: any, value: any) => {
       if (value instanceof Set) {
 
         if (mapping.setType === 'bigint') {
-          mapping.setType = 'number'
           value = Array.from(value).map((n) => toDynamoBigInt(n))
         }
 
@@ -78,7 +77,6 @@ export default () => (mapping: any, field: any, value: any) => {
         const actualSetType = typeOf(value[0])?.toLowerCase?.()
 
         if (mapping.setType === 'bigint') {
-          mapping.setType = 'number'
           value = value.map((n) => toDynamoBigInt(n))
         }