feature: add typings and build with typescript compiler #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrunkat
requested review from
jirimoravcik and
mhamas
and removed request for
gippy
|
Hello @sveisvei, we actually have a TS config available, could you please make it so you extend it? The repository is here https://github.com/apify/apify-tsconfig |
|
@jirimoravcik fixed
|
mhamas
approved these changes
Jan 5, 2022
jirimoravcik
approved these changes
Jan 5, 2022
|
@sveisvei New version is released as |
|
@jirimoravcik Thank you, will switch to this from my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed typescript typings, so ended up using the typescript compiler to allow js and output sensible node compatible code.