Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update registry-experimental command constructors to match the registry tool's #142

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Update registry-experimental command constructors to match the registry tool's #142

merged 1 commit into from
Feb 16, 2023

Conversation

timburks
Copy link
Contributor

Fixes #139.

timburks
timburks commented Feb 16, 2023
View reviewed changes
cmd/registry-experimental/cmd/root.go
cmd.AddCommand(search.Command(ctx))
cmd.AddCommand(wipeout.Command(ctx))

cmd.PersistentFlags().StringVar(&logID, "log-id", "", "Assign an ID which gets attached to the log produced")
Copy link
Contributor Author

@timburks timburks Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seaneganx do we need this --log-id flag? I don't see it in the main repo.

@timburks timburks merged commit 0d3d2d3 into apigee:main Feb 16, 2023
@timburks timburks deleted the cmd-updates branch September 18, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theganyo theganyo theganyo approved these changes

@seaneganx seaneganx seaneganx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Apigee API Registry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registry-experimental: code structure is lagging behind the registry tool
3 participants
@timburks @theganyo @seaneganx