restructure/clean up extract subcommand and extract pkg/yamlquery
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unneeded print statements from
registry-experimental extractand pulls the yaml querying functions out into a separate package so they can be easily reused (I had already copied them into an external project and this will replace that copied code).The purpose of
pkg/yamlqueryis to make it easy to pull values out of YAML structures created by the yaml/v3 package. There might be other packages that do this, but I didn't see them, and this is lightweight and easy to modify (and we can toss it if we do find a replacement).I created an issue for testing the new package (#152).