Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Redis as session store #4

Merged
merged 6 commits into from
Sep 15, 2017
Merged

Added support for Redis as session store #4

merged 6 commits into from
Sep 15, 2017

Conversation

achwie
Copy link
Collaborator

@achwie achwie commented Jul 31, 2017

Added support for Redis as session store (via env variable SESSION_STORE_TYPE). Fixes Haufe-Lexware/wicked.haufe.io#83

@achwie achwie requested a review from DonMartin76 July 31, 2017 08:11
@achwie achwie changed the base branch from master to next July 31, 2017 08:12
DonMartin76
DonMartin76 approved these changes Sep 1, 2017
View reviewed changes
Copy link
Member

@DonMartin76 DonMartin76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach, but it needs to be documented. We can pull in this into 0.12.0, but after that, we need to add documentation to it.

@DonMartin76 DonMartin76 merged commit 799959d into next Sep 15, 2017
@DonMartin76 DonMartin76 deleted the feat/redis-sessionstore branch September 15, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonMartin76 DonMartin76 DonMartin76 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achwie @DonMartin76