-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gqlgen to v0.17.45 #606
update gqlgen to v0.17.45 #606
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@dariuszkuc I'm not sure if I need to do anything else to regenerate the test results summary page. |
Apollo Federation Subgraph Compatibility Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you might want to uncomment
apollo-federation-subgraph-compatibility/implementations/gqlgen/graph/schema.graphqls
Line 68 in ff24a67
# @requires(fields: "totalProductsCreated yearsOfEmployment") |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@jesse-apollo You will probably need to pick this up and carry this PR the rest of the way home, as I'm traveling and it's hard to code on my phone while driving. 😆 |
Hi @StevenACoffman I'll take a look at this today. |
@StevenACoffman I've got everything passing locally. Do you want to close this PR and I'll create a new one or add me to your test repo? Or I can PR against your test repo. |
Here are my changes: jesse-apollo@26e9536 |
Apollo Federation Subgraph Compatibility Results
|
I added your commit to this PR, but I'm fine either way! |
Apollo Federation Subgraph Compatibility Results
|
@dariuszkuc How does the website get updated with this new info? |
👋 its a manual step - I'll update it today or tomorrow. |
This updates gqlgen to v0.17.45