Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gqlgen to v0.17.45 #606

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

StevenACoffman
Copy link
Contributor

This updates gqlgen to v0.17.45

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman requested a review from a team as a code owner March 11, 2024 23:37
@StevenACoffman
Copy link
Contributor Author

@dariuszkuc I'm not sure if I need to do anything else to regenerate the test results summary page.

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🔲
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🔲
@interfaceObject🔲

Copy link
Member

@dariuszkuc dariuszkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you might want to uncomment

# @requires(fields: "totalProductsCreated yearsOfEmployment")

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Contributor Author

@jesse-apollo You will probably need to pick this up and carry this PR the rest of the way home, as I'm traveling and it's hard to code on my phone while driving. 😆

@jesse-apollo
Copy link

Hi @StevenACoffman I'll take a look at this today.

@jesse-apollo
Copy link

@StevenACoffman I've got everything passing locally. Do you want to close this PR and I'll create a new one or add me to your test repo? Or I can PR against your test repo.

@jesse-apollo
Copy link

Here are my changes: jesse-apollo@26e9536

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🔲
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🔲
@interfaceObject🔲

@StevenACoffman
Copy link
Contributor Author

I added your commit to this PR, but I'm fine either way!

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

@dariuszkuc dariuszkuc merged commit 7c6f6f0 into apollographql:main Mar 12, 2024
5 checks passed
@StevenACoffman StevenACoffman deleted the update_gqlgen_v0_17_45 branch March 13, 2024 00:08
@StevenACoffman
Copy link
Contributor Author

@dariuszkuc How does the website get updated with this new info?

@dariuszkuc
Copy link
Member

👋 its a manual step - I'll update it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants