Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TryFrom impls to convert from hir to encoder types (#424) #466

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

zackangelo
Copy link
Contributor

@zackangelo zackangelo commented Mar 1, 2023

Took a shot at implementing these conversion impls. The issue mentioned that the approach required is dependent on some other decisions. Let me know if this aligns with the direction you'd like to take and I'll clean up and add some tests.

Fixes #424

@apollo-cla
Copy link

@zackangelo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@lrlna
Copy link
Member

lrlna commented Mar 2, 2023

@zackangelo thank you for attempting to tackle this!

I think we need to scope out a few more use cases and a direction for #420 before committing to implementing #424. I am not super keen to add extra API surface area before then. I'll keep this PR open for now, and give you a shout if we end up needing a TryFrom for the encoder types.

@zackangelo
Copy link
Contributor Author

Sounds great, please let me know if I can be of further help.

@lrlna
Copy link
Member

lrlna commented Apr 24, 2023

@zackangelo i thought about it some more, and regardless to our decision on #420, this would be a useful addition. especially for testing :)

@lrlna lrlna merged commit 183ae48 into apollographql:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tryfrom for HIR types for apollo_encoder types
3 participants