breaking: drop deprecated graphql-java-support-api package #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR drops the `graphql-java-support-api` package.
`graphql-java` v17 introduced new GraphQLContext mechanism which standardized how context should be utilized. Prior to v17, context could be of any object and it was up to the developers to decide how it should look like. This old "any" object context mechanism is currently deprecated and will be removed in future versions of `graphql-java`. New GraphQLContext standardizes the approach and is a simple wrapper around a map.
`graphql-java-support-api` contained single `HTTPRequestHeaders` interface that was used by old/deprecated context mechanism to indicate whether `GraphQLContext` ("any" object) supports federated tracing. Starting with [v0.9.0](https://github.com/apollographql/federation-jvm/releases/tag/v0.9.0), `federation-jvm` already supports `FederationTracingInstrumentation` through the new GraphQLContext map mechanism.
Resolves: apollographql#190
dariuszkuc
added
the
change: major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the
graphql-java-support-apipackage.graphql-javav17 introduced new GraphQLContext mechanism which standardized how context should be utilized. Prior to v17, context could be of any object and it was up to the developers to decide how it should look like. This old "any" object context mechanism is currently deprecated and will be removed in future versions ofgraphql-java. "New" GraphQLContext standardizes the approach and is a simple wrapper around a map.graphql-java-support-apicontained singleHTTPRequestHeadersinterface that was used by old/deprecated context mechanism to indicate whetherGraphQLContext("any" object) supports federated tracing. Starting with v0.9.0,federation-jvmalready supportsFederationTracingInstrumentationthrough the new GraphQLContext map mechanism.Resolves: #190