chore: Update graphql rule imports to support graphql@16 users (v2) #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitively don't mind having this committed, but this made me realise we misses some dead code removal in #1155 as this file is now unused in federation 2 (afaict the only place where graphql-js rules are imported and used now is here and it uses the "proper" names). I have created #1208 to remove the file impacting by this PR as well a number of other unused files, which would make this "obsolete" (but again, don't mind if we just commit that temporarily). |
|
Closing this, as @pcmanus notes it's effectively obsoleted by his PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1175