RemoteGraphQLDataSource uses make-fetch-happen by default
#1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the subject says. Couple of things that I'm not sure about. 1. When I make a call to `.defaults()` do I need to pass any extra parameters? Didn't look like the `node-fetch` version did, but I want to make sure we don't want to add any extra headers or anything. For reasons stated in #192, I'm being careful and turning off retries completely, but I believe this was also the case in `node-fetch` 2. Obviously this needs to get into the CHANGELOG, but I'm assuming we do that when we cut a new version?
clenfest
force-pushed
the
clenfest/issue180
branch
from
f8c35f6
to
97b7bda
Compare
trevor-scheer
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
This LGTM. It should get a CHANGELOG entry with this PR (ping if you'd like any guidance there).
As a side note, I'd like to see us move away from mocking the fetcher objects and just using nock instead. Mocking the module (as is the status quo in this case) adds a layer of convention / magic which isn't well-documented and isn't really the convention for mocking network requests within this repo (typically we use nock). I'll open a separate issue for this.
gateway-js/src/datasources/__tests__/RemoteGraphQLDataSource.test.ts
Outdated
Show resolved
Hide resolved
|
Also, would like to land this on |
abernix
added
the
↪️ backport-to-0.x
|
Agree created #1379 for the backport |
clenfest
added a commit
that referenced
this pull request
Jan 13, 2022
* RemoteGraphQLDataSource uses `make-fetch-happen` by default
clenfest
added a commit
that referenced
this pull request
Jan 13, 2022
* RemoteGraphQLDataSource uses `make-fetch-happen` by default (#1284) * RemoteGraphQLDataSource uses `make-fetch-happen` by default * fix location of merge comment * update CHANGELOG with backport PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the subject says. Couple of things that I'm not sure about.
When I make a call to
.defaults()do I need to pass any extra parameters? Didn't look like thenode-fetchversion did, but I want to make sure we don't want to add any extra headers or anything. For reasons stated in Apollo Gateway: Add make-fetch-happen fetcher as the default fetcher for the downstream services #192, I'm being careful and turning off retries completely, but I believe this was also the case innode-fetchObviously this needs to get into the CHANGELOG, but I'm assuming we do that when we cut a new version?
Fixes #192
Fixes #1232