Preserve default values for input object fields when extracting subgraph #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
cysp
force-pushed
the
fix/extract-subgraph-input-field-default-value
branch
from
6ec0956
to
d643431
Compare
pcmanus
approved these changes
Oct 26, 2022
cysp
force-pushed
the
fix/extract-subgraph-input-field-default-value
branch
from
d643431
to
6f02b6a
Compare
|
Sure no worries, I used about the same wording as I used in the PR title here but if you have other ideas about wording I believe you can modify this branch (I've ticked a box that sounds like it allows that, "allow edits by maintainers") 🙂 |
pcmanus
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Release (#2215) - @apollo/composition@2.1.4 - apollo-federation-integration-testsuite@2.1.4 - @apollo/gateway@2.1.4 - @apollo/federation-internals@2.1.4 - @apollo/query-graphs@2.1.4 - @apollo/query-planner@2.1.4 - @apollo/subgraph@2.1.4 * Preserve default values for input object fields when extracting subgraph (#2218) * Update opentelemetry.mdx comment for default Collector URL (#2221) According to https://www.npmjs.com/package/@opentelemetry/exporter-trace-otlp-http, the default URL used by this particular constructor is http://localhost:4318/v1/traces. This updated comment should be more correct and explicit, in that we also expect a default path of `/v1/traces` * changelog entries got a little mixed up Co-authored-by: Jeff Jakub <jeffjakub@users.noreply.github.com> Co-authored-by: Scott Talbot <s@chikachow.org> Co-authored-by: Kevin Lin <kevin.lin@flexport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve default values for input object fields when extracting subgraph from super graph
Fixes #2174.
The previous attempt at this problem in #2176 took the default value of an input object field into account when validating a query document against the schema, but it turns out that input object fields' default values are being dropped before we get to that point, when we extract a subgraph from the supergraph.
This code change solves my problem in practice. 🙂