Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to omit join__ directives from being cloned #3053

Merged
merged 2 commits into from
Jul 8, 2024
Merged

add ability to omit join__ directives from being cloned #3053

merged 2 commits into from
Jul 8, 2024

Conversation

clenfest
Copy link
Contributor

For very large graphs cloning types with lots of join directives can be expensive. Since these directives will not be used in the Schema that is cloned for toAPISchema(), add the ability to optionally omit them

@clenfest clenfest requested a review from a team as a code owner June 27, 2024 23:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 6adc871

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit c3a511d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667df9ff8e7f2d00087e669b

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 27, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde sachindshinde changed the base branch from main to version-2.8.3-beta July 8, 2024 19:38
@sachindshinde sachindshinde merged commit f753d55 into version-2.8.3-beta Jul 8, 2024
19 checks passed
@sachindshinde sachindshinde deleted the clenfest/join_cloning branch July 8, 2024 19:43
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Merged
sachindshinde pushed a commit that referenced this pull request Jul 9, 2024
@github-actions
release: on branch version-2.8.3-beta (beta) (#3065)
f560372 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to
version-2.8.3-beta, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-2.8.3-beta` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `version-2.8.3-beta`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @apollo/composition@2.8.3-beta.0

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Add a fast path to skip override validation for fields without any
subgraph `@override`s.
([#3070](#3070))

- Type merging now uses maps instead of sparsely-populated arrays for
per-subgraph data.
([#3069](#3069))

- Stop duplicating hints for inconsistent value type fields per
subgraph.
([#3071](#3071))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/gateway@2.8.3-beta.0

### Patch Changes

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`67b70c6e68b1cdbf8f03dacafd636e27ed9b7814`](67b70c6),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`f5f6a799d6b3675eecb0eaec7a816d746cd136b2`](f5f6a79),
[`42bd27af6a23bcfdd36951dbfa3fb9f7ba833f3a`](42bd27a),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/composition@2.8.3-beta.0
    -   @apollo/query-planner@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/federation-internals@2.8.3-beta.0

### Patch Changes

- For very large graphs cloning types with lots of join directives can
be expensive. Since these directives will not be used in the Schema that
is cloned for toAPISchema(), add the ability to optionally omit them
([#3053](#3053))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

## @apollo/query-graphs@2.8.3-beta.0

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Updated dependencies
\[[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/query-planner@2.8.3-beta.0

### Patch Changes

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/subgraph@2.8.3-beta.0

### Patch Changes

- Updated dependencies
\[[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3-beta.0

## apollo-federation-integration-testsuite@2.8.3-beta.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jul 12, 2024
Open
Merged
sachindshinde pushed a commit that referenced this pull request Jul 12, 2024
@github-actions
release: on branch main (#3055)
1a55925 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/composition@2.8.3

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Add a fast path to skip override validation for fields without any
subgraph `@override`s.
([#3070](#3070))

- Type merging now uses maps instead of sparsely-populated arrays for
per-subgraph data.
([#3069](#3069))

- Stop duplicating hints for inconsistent value type fields per
subgraph.
([#3071](#3071))

- Fix logic to compute missing subgraphs when generating composition
hints/errors
([#3076](#3076))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3
    -   @apollo/federation-internals@2.8.3

## @apollo/gateway@2.8.3

### Patch Changes

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`67b70c6e68b1cdbf8f03dacafd636e27ed9b7814`](67b70c6),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`f5f6a799d6b3675eecb0eaec7a816d746cd136b2`](f5f6a79),
[`42bd27af6a23bcfdd36951dbfa3fb9f7ba833f3a`](42bd27a),
[`f376447a820e3c0ae41d16d1fd3b681d2f1e8c14`](f376447),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/composition@2.8.3
    -   @apollo/federation-internals@2.8.3
    -   @apollo/query-planner@2.8.3

## @apollo/federation-internals@2.8.3

### Patch Changes

- dummy commit to force beta.2
([#3078](#3078))

- For very large graphs cloning types with lots of join directives can
be expensive. Since these directives will not be used in the Schema that
is cloned for toAPISchema(), add the ability to optionally omit them
([#3053](#3053))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

## @apollo/query-graphs@2.8.3

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3

## @apollo/query-planner@2.8.3

### Patch Changes

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3
    -   @apollo/federation-internals@2.8.3

## @apollo/subgraph@2.8.3

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3

## apollo-federation-integration-testsuite@2.8.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clenfest @sachindshinde