Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure we are removing ALL useless groups #3163

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: ensure we are removing ALL useless groups #3163

merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. fix: ensure we are removing ALL useless groups 

    When removing "useless" fetch nodes/groups we remove them in-place while still iterating over the same list. This leads to potentially skipping processing of some the children fetch nodes, as when we remove nodes we left shift all remaining children but the iterator keeps the old position unchanged effectively skipping next child.
    @dariuszkuc
    dariuszkuc committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    174d31d View commit details
    Browse the repository at this point in the history

  2. add test and changeset

    @dariuszkuc
    dariuszkuc committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d3387dd View commit details
    Browse the repository at this point in the history