Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): add configurable histogram buckets for metrics #3098

Merged
merged 4 commits into from
May 30, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 16, 2023

You can customize the buckets for all generated histograms:

telemetry:
  metrics:
    common:
      buckets:
        - 0.05
        - 0.10
        - 0.25
        - 0.50
        - 1.00
        - 2.50
        - 5.00
        - 10.00
        - 20.00

Fixes #2333

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from StephenBarlow as a code owner May 16, 2023 13:13
@bnjjj bnjjj self-assigned this May 16, 2023
@router-perf
Copy link

router-perf bot commented May 16, 2023

CI performance tests

  • pr - Basic stress test that finds the max RPS when no features are configured
  • reload - Reload test over a long period of time at a constant rate of users

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from BrynCooke May 18, 2023 13:48
@bnjjj bnjjj merged commit 1259982 into dev May 30, 2023
@bnjjj bnjjj deleted the bnjjj/feat_2333 branch May 30, 2023 08:19
@garypen garypen mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: Configurable histogram bucket dimensions
2 participants