-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity cache: support queries with private scope #4855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
bnjjj
approved these changes
Apr 17, 2024
BrynCooke
approved these changes
Apr 17, 2024
different subgraphs might use different options, and the `sub` claim from the JWT might not be used directly, so we make it configurable
abernix
added a commit
that referenced
this pull request
May 6, 2024
#4855 Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for caching responses marked with the
private
scope. For now, this is meant to work only from what the subgraph is returning, without any schema level information.this encodes the following behaviour:
Cache-Control: private
for a query, then it works as usualCache-Control: private
for a query:private_id
option and the related data is found in context provided by the authentication plugin, then we look for the cache entry for this query, by adding a hash of theprivate_id
to the cache key. If not present, we perform the query, and then store the data at this personalized cache keyprivate_id
, the we do not cache the response because we have no way to distinguish usersprivate_id
hash) because we cannot know in advance if it requires private dataCache-Control: private
private_id
: since we don't have a way to differentiate users, then we do not cache the responseChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩