chore: Include stdout as well if apksigner fails (#553)

appium · Sep 23, 2020 · 2a12f8a · 2a12f8a
1 parent e128828
commit 2a12f8a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/tools/apk-signing.js b/lib/tools/apk-signing.js
@@ -22,7 +22,7 @@ const DEFAULT_CERT_HASH = {
 };
 
 
-let apkSigningMethods = {};
+const apkSigningMethods = {};
 
 /**
  * Execute apksigner utility with given arguments.
@@ -79,7 +79,7 @@ apkSigningMethods.signWithDefaultCert = async function signWithDefaultCert (apk)
     await this.executeApksigner(args);
   } catch (e) {
     throw new Error(`Could not sign '${apk}' with the default certificate. ` +
-      `Original error: ${e.stderr || e.message}`);
+      `Original error: ${e.stderr || e.stdout || e.message}`);
   }
 };
 
@@ -107,7 +107,7 @@ apkSigningMethods.signWithCustomCert = async function signWithCustomCert (apk) {
       apk]);
   } catch (err) {
     log.warn(`Cannot use apksigner tool for signing. Defaulting to jarsigner. ` +
-      `Original error: ${err.stderr || err.message}`);
+      `Original error: ${err.stderr || err.stdout || err.message}`);
     try {
       if (await unsignApk(apk)) {
         log.debug(`'${apk}' has been successfully unsigned`);