adb-commands module refactoring #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting, getSetting]
… of `isScreenLocked()`.
… statement in `getSetting`.
lib/tools/adb-commands.js
Outdated
| }; | ||
|
|
||
| methods.setSetting = async function (namespace, setting, value) { | ||
| await this.shell(['settings', 'put', namespace, setting, value]); |
There was a problem hiding this comment.
return might be also useful here
|
Linting is broken. Please run |
…`. Bypass lint error for chai `should`.
lib/tools/adb-commands.js
Outdated
| }; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Please rebase your branch with the recent master to see docstring examples. We do follow JSDoc tutorial while creating docstrings.
jlipps
approved these changes
Sep 11, 2017
| @@ -7,7 +7,7 @@ import { apiLevel, platformVersion, MOCHA_TIMEOUT } from './setup'; | |||
| import { fs, mkdirp } from 'appium-support'; | |||
| import temp from 'temp'; | |||
|
|
|||
|
|
|||
| const should = chai.should(); | |||
There was a problem hiding this comment.
the way that i usually get around lint errors here is simply:
chai.should();i.e., you don't need to assign it to a variable for it to do the thing you need it to do.
|
Thanks! Functional tests pass locally, and fix for Travis is in master, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.