refactor: Fetch java executable location from PATH if JAVA_HOME is unset #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Aug 4, 2021
jlipps
approved these changes
Aug 4, 2021
| } | ||
| } | ||
| try { | ||
| return await fs.which(executableName); |
There was a problem hiding this comment.
should we generalize this for other binaries, not just java?
There was a problem hiding this comment.
which binaries exactly you'd like to generalize?
There was a problem hiding this comment.
i'm not sure, don't we do similar logic currently for binaries inside ANDROID_HOME, and, e.g., jarsigner?
There was a problem hiding this comment.
jarsigner is only used as a fallback if apksigner fails for some reason, so I would rather leave it as is for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to appium/appium#15693