Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing an error if Appium Settings fails to provide geolocation values #493

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

Geolocation providers require some time to get the actual info. Also, one doesn't always care about getting the current geolocation value geolocation is being set.

@mykola-mokhnach
Copy link
Contributor Author

@jlipps
Copy link
Member

jlipps commented Jan 23, 2019

hopefully no one was relying on the exception behavior :-)

@mykola-mokhnach mykola-mokhnach merged commit dfbb074 into appium:master Jan 24, 2019
@mykola-mokhnach mykola-mokhnach deleted the set_geo branch January 28, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants